You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/09/03 00:10:18 UTC

[GitHub] [iceberg] rdblue commented on pull request #1177: Add schema upsert API for adding new fields and updating type (where applicable) using an input schema

rdblue commented on pull request #1177:
URL: https://github.com/apache/iceberg/pull/1177#issuecomment-686151932


   @fbocse, this looks good to me! Once the public method name and Javadoc are fixed, I'm +1. It would also be nice to merge `TypeVisitor` back into `SchemaWithPartnerVisitor` unless there's some independent use for it that I'm missing.
   
   @rdsr, what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org