You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/09 02:35:45 UTC

[GitHub] [incubator-kyuubi] jiaoqingbo opened a new issue #2066: [Bug] there are Spelling mistakes and inappropriate naming

jiaoqingbo opened a new issue #2066:
URL: https://github.com/apache/incubator-kyuubi/issues/2066


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the bug
   
   In TFrontendService.scala the comment **hive-service-prc** should be **hive-service-rpc**
   
   the **HiveTBinaryFrontend.scala** should be rename to **HiveTBinaryFrontendService** 
    ，the same pattern as **SparkTBinaryFrontendService**、**FlinkTBinaryFrontendService**
   
   ### Affects Version(s)
   
   master
   
   ### Kyuubi Server Log Output
   
   _No response_
   
   ### Kyuubi Engine Log Output
   
   _No response_
   
   ### Kyuubi Server Configurations
   
   _No response_
   
   ### Kyuubi Engine Configurations
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2066: [Bug] there are Spelling mistakes and inappropriate naming

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2066:
URL: https://github.com/apache/incubator-kyuubi/issues/2066#issuecomment-1062508706


   Ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] jiaoqingbo commented on issue #2066: [Bug] there are Spelling mistakes and inappropriate naming

Posted by GitBox <gi...@apache.org>.
jiaoqingbo commented on issue #2066:
URL: https://github.com/apache/incubator-kyuubi/issues/2066#issuecomment-1062501152


   
   
   
   
   > lets rm the service from spark and flink instead？be shorter be better
   may be more appropriate to keep the service suffix for consistency
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #2066: [Bug] there are Spelling mistakes and inappropriate naming

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #2066:
URL: https://github.com/apache/incubator-kyuubi/issues/2066#issuecomment-1062502397


   > lets rm the service from spark and flink instead？be shorter be better
   
   @yaooqinn, IMO, it's better to rename by adding `Service` which is directly known as service.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2066: [Bug] there are Spelling mistakes and inappropriate naming

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2066:
URL: https://github.com/apache/incubator-kyuubi/issues/2066#issuecomment-1062498152


   lets rm the service from spark and flink instead？be shorter be better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed issue #2066: [Bug] there are Spelling mistakes and inappropriate naming

Posted by GitBox <gi...@apache.org>.
yaooqinn closed issue #2066:
URL: https://github.com/apache/incubator-kyuubi/issues/2066


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org