You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/04/14 21:59:42 UTC
[GitHub] [pinot] shenyu0127 opened a new issue, #10618: Refactor to eliminate repeated code in transformToIntValuesSVWithNull
shenyu0127 opened a new issue, #10618:
URL: https://github.com/apache/pinot/issues/10618
Problem:
In our current implementation, `transformToIntValuesSVWithNull` repeats most of the code in `transformToIntValuesSV`, ([e.g.](https://github.com/shenyu0127/pinot/blob/003b2a825623da54781cefb9e488e372433820f5/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java#L184)). This reduces code maintainability if the `transformToIntValuesSV` function is long ([e.g.](https://github.com/shenyu0127/pinot/blob/003b2a825623da54781cefb9e488e372433820f5/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java#L140)) and we want to add a corresponding `transformToIntValuesSVWithNull`.
Solution:
Figure out a way to refactor to eliminate repeated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 closed issue #10618: Refactor to eliminate repeated code in transformToIntValuesSVWithNull
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 closed issue #10618: Refactor to eliminate repeated code in transformToIntValuesSVWithNull
URL: https://github.com/apache/pinot/issues/10618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on issue #10618: Refactor to eliminate repeated code in transformToIntValuesSVWithNull
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on issue #10618:
URL: https://github.com/apache/pinot/issues/10618#issuecomment-1631238278
We no longer need to refactor because we redesigned the transformation NULL support and deleted the `transformToXxValuesSVWithNull` APIs in https://github.com/apache/pinot/pull/11008.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org