You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/13 17:42:51 UTC
[GitHub] [geode] mivanac opened a new pull request #5248: GEODE-8247: solution and new tests added
mivanac opened a new pull request #5248:
URL: https://github.com/apache/geode/pull/5248
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [*] Is your initial contribution a single, squashed commit?
- [*] Does `gradlew build` run cleanly?
- [*] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo commented on a change in pull request #5248: GEODE-8247: modified FilterRoutingInfo checks
Posted by GitBox <gi...@apache.org>.
mkevo commented on a change in pull request #5248:
URL: https://github.com/apache/geode/pull/5248#discussion_r439802278
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
+ }
+
+ @Override
+ public void close() {
+
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac merged pull request #5248: GEODE-8247: modified FilterRoutingInfo checks
Posted by GitBox <gi...@apache.org>.
mivanac merged pull request #5248:
URL: https://github.com/apache/geode/pull/5248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mkevo commented on a change in pull request #5248: GEODE-8247: modified FilterRoutingInfo checks
Posted by GitBox <gi...@apache.org>.
mkevo commented on a change in pull request #5248:
URL: https://github.com/apache/geode/pull/5248#discussion_r439801370
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
Review comment:
Please change names, e.g. onEventCalls -> **onEventCreateCalls**, onEventUPDATE -> **onEventUpdateCalls**
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
Review comment:
remove blank line
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
+ }
+
+ @Override
+ public void close() {
+
Review comment:
remove blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] mivanac commented on a change in pull request #5248: GEODE-8247: modified FilterRoutingInfo checks
Posted by GitBox <gi...@apache.org>.
mivanac commented on a change in pull request #5248:
URL: https://github.com/apache/geode/pull/5248#discussion_r439802028
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQDistributedTest.java
##########
@@ -196,6 +252,32 @@ public void close() {
}
}
+ private class TestCqListener2 implements CqListener, Serializable {
+ public int onEventCalls = 0;
+ public int onEventUPDATE = 0;
+
+ @Override
+ public void onEvent(CqEvent aCqEvent) {
+ Operation queryOperation = aCqEvent.getQueryOperation();
+ if (queryOperation.isCreate()) {
+ onEventCalls++;
+ } else if (queryOperation.isUpdate()) {
+ onEventUPDATE++;
+ }
+ }
+
+ @Override
+ public void onError(CqEvent aCqEvent) {
+
+ }
+
+ @Override
+ public void close() {
+
Review comment:
Thanks for comments. Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org