[GitHub] [arrow] danepitkin commented on a diff in pull request #36934: GH-36069: [Java] Ensure S3 is finalized on shutdown

["danepitkin (via GitHub)" <gi...@apache.org>]

danepitkin commented on code in PR #36934:
URL: https://github.com/apache/arrow/pull/36934#discussion_r1278075653


##########
java/dataset/src/main/java/org/apache/arrow/dataset/file/FileSystemDatasetFactory.java:
##########
@@ -26,14 +28,18 @@
  */
 public class FileSystemDatasetFactory extends NativeDatasetFactory {
 
+  private static final AtomicBoolean addedS3ShutdownHook = new AtomicBoolean(false);

Review Comment:
   I added an atomic check to ensure we only register a single hook. Without it, we could register multiple hooks to call `EnsureS3Finalized`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org