[jira] Updated: (THRIFT-343) #import unnecessary and borks iPhone compilation

["Matt Stevens (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Stevens updated THRIFT-343:
--------------------------------

    Attachment: thrift-343-foundation.patch

Another solution is to just replace the Cocoa import with Foundation. Cocoa.h is a convenience header that imports Foundation, AppKit, and CoreData. Thrift depends only on Foundation, which is available on both the Mac and the iPhone. Making this switch will provide iPhone support without introducing a dependency on a project's PCH.

Attaching a patch that does this.

> #import <Cocoa/Cocoa.h> unnecessary and borks iPhone compilation
> ----------------------------------------------------------------
>
>                 Key: THRIFT-343
>                 URL: https://issues.apache.org/jira/browse/THRIFT-343
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Cocoa)
>         Environment: iPhone
>            Reporter: Andrew McGeachie
>            Assignee: Andrew McGeachie
>            Priority: Minor
>         Attachments: thrift-343-foundation.patch
>
>
> The Cocoa generator currently sticks a "#import <Cocoa/Cocoa.h>" line at the top of generated files.  This is actually unnecessary because of Xcode's default precompiled header file, and it borks when compiling for the iPhone, making code sharing between Cocoa and iPhone code a pain.
> Solution: remove the import.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.