You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/07 06:47:59 UTC
[GitHub] [iotdb] zyk990424 commented on a change in pull request #4720: Add compatible interface with 0.12.x for creating template of flat measurements
zyk990424 commented on a change in pull request #4720:
URL: https://github.com/apache/iotdb/pull/4720#discussion_r780058936
##########
File path: session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java
##########
@@ -1380,6 +1380,43 @@ public void createSchemaTemplate(Template template)
}
}
+ /**
+ * Create a template with flat measurements, not tree structured. Need to specify datatype,
+ * encoding and compressor of each measurement, and alignment of these measurements at once.
+ *
+ * @oaram templateName name of template to create
+ * @param measurements flat measurements of the template, cannot contain character dot
+ * @param dataTypes datatype of each measurement in the template
+ * @param encodings encodings of each measurement in the template
+ * @param compressors compression type of each measurement in the template
+ * @param isAligned specify whether these flat measurements are aligned
+ */
+ public void createSchemaTemplate(
+ String templateName,
+ List<String> measurements,
+ List<TSDataType> dataTypes,
+ List<TSEncoding> encodings,
+ List<CompressionType> compressors,
+ boolean isAligned)
Review comment:
Is there "isAligned" parameter in the interface of v0.12? If not, should we add a same interface as that of 0.12 and use default isAligned = false ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org