You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/05/26 02:37:18 UTC

[GitHub] [calcite] tisonkun edited a comment on pull request #2411: Add generic info to Map & Array annotation

tisonkun edited a comment on pull request #2411:
URL: https://github.com/apache/calcite/pull/2411#issuecomment-848410856


   @rubenada @zabetak @amaliujia  thanks for your time!
   
   > Just out of curiosity: what is the benefit to have generic info?
   
   @amaliujia I think adding generic parameter when there should be one is a general best practice. It is useful as linter in this case.
   
   I created this pull request on a day reading the source code and linter complain. The community may or may not reject such pr and require to be included in a larger one, but I prefer we accept valid contributions at any level. If you turn a blind eye to generic parameter missing, it is possible we are gonna run into a case where Apache Hudi is, that it is hard to fix missing generic parameters that really hurt.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org