[jira] [Comment Edited] (PHOENIX-5967) phoenix-client transitively pulling in phoenix-core

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141014#comment-17141014 ] 

Istvan Toth edited comment on PHOENIX-5967 at 6/20/20, 8:38 AM:
----------------------------------------------------------------

You are right.

BTW the -server jars probably have the same problem, though in that case it's unlikely that someone install JARS to HBase classpath via maven.

I've enabled <shadedArtifactAttached> so that we're able to have multiple versions of the shaded jar, and distinguish them, but this results in having the unshaded dependencies in the POM.

disabling shadedArtifactAttached fixes the POM, we'll have clashes with the clients builts with different HBase versions.

To solve this we could :

* add the hbase version to the artifactId Instead
* use some other maven trick to set the classifier - I did not find any, others may
* ditch the hbase specific artifacts, and go with the solution suggested by [~larsh] in PHOENIX-5902 (i.e. build the -client with the oldest Hbase version, and don't shade the compatibility module into the -server jar)



was (Author: stoty):
You are right.

I've enabled <shadedArtifactAttached> so that we're able to have multiple versions of the shaded jar, and distinguish them, but this results in having the unshaded dependencies in the POM.

disabling shadedArtifactAttached fixes the POM, we'll have clashes with the clients builts with different HBase versions.

To solve this we could :

* add the hbase version to the artifactId Instead
* use some other maven trick to set the classifier - I did not find any, others may
* ditch the hbase specific artifacts, and go with the solution suggested by [~larsh] in PHOENIX-5902 (i.e. build the -client with the oldest Hbase version, and don't shade the compatibility module into the -server jar)


> phoenix-client transitively pulling in phoenix-core
> ---------------------------------------------------
>
>                 Key: PHOENIX-5967
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5967
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>
> Looks like something happened in master where phoenix-client is now transitively pulling in phoenix-core, even though all of phoenix-core and its dependencies are included in the phoenix-client shaded artifact.
> 4.15.0 looks OK, so maybe something inadvertent with the hbase version classifier stuff, [~stoty]?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)