You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "bmscomp (via GitHub)" <gi...@apache.org> on 2023/07/23 00:21:49 UTC

[GitHub] [kafka] bmscomp opened a new pull request, #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

bmscomp opened a new pull request, #14075:
URL: https://github.com/apache/kafka/pull/14075

   Fixing the Jacoco report generation issue, in the current Gradle version 8.x 
   
   ### Committer Checklist (excluded from commit message)
   - [x] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [x] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ex172000 commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271382072


##########
build.gradle:
##########
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
     executionData.from = javaProjects.jacocoTestReport.executionData
 
     reports {
-      html.enabled = true
-      xml.enabled = true
+      xml.required = true

Review Comment:
   Is there a reason to have two duplicated lines?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14075:
URL: https://github.com/apache/kafka/pull/14075#issuecomment-1652253193

   Test failures are not related. Merging this one. Nice catch @bmscomp! I am surprised that this wasn't caught earlier. I will also backport this to 3.5.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] bmscomp commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "bmscomp (via GitHub)" <gi...@apache.org>.
bmscomp commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437691


##########
build.gradle:
##########
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
     executionData.from = javaProjects.jacocoTestReport.executionData
 
     reports {
-      html.enabled = true
-      xml.enabled = true
+      xml.required = true

Review Comment:
   @ex172000  I did not only duplicate the xml configuration I also removed the html configuration and this is fixed now 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] bmscomp commented on pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "bmscomp (via GitHub)" <gi...@apache.org>.
bmscomp commented on PR #14075:
URL: https://github.com/apache/kafka/pull/14075#issuecomment-1647817977

   
   @divijvaidya  Before those changes, the generation of tests jacoco coverage report fails because of this error 
   
   `"Could not set unknown property 'enabled' for Report html of type org.gradle.api.reporting.internal.TaskGeneratedSingleDirectoryReport"`
   
   With the related changes, the generation of the coverage reports works and the reports (xml and html) are well generated in  `build/reports/jacoco/test/html/index.html` and `build/reports/jacoco/test/jacocoTestReport.xml ` paths 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ex172000 commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "ex172000 (via GitHub)" <gi...@apache.org>.
ex172000 commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271558534


##########
build.gradle:
##########
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
     executionData.from = javaProjects.jacocoTestReport.executionData
 
     reports {
-      html.enabled = true
-      xml.enabled = true
+      xml.required = true

Review Comment:
   Nice, thank you for the explanation! New to the project so asked to learn :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] bmscomp commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "bmscomp (via GitHub)" <gi...@apache.org>.
bmscomp commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437161


##########
build.gradle:
##########
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
     executionData.from = javaProjects.jacocoTestReport.executionData
 
     reports {
-      html.enabled = true
-      xml.enabled = true
+      xml.required = true

Review Comment:
   No reason l will fit it now 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya merged pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya merged PR #14075:
URL: https://github.com/apache/kafka/pull/14075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] divijvaidya commented on pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on PR #14075:
URL: https://github.com/apache/kafka/pull/14075#issuecomment-1647805630

   Please add how did you test this and the before/after results. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] bmscomp commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

Posted by "bmscomp (via GitHub)" <gi...@apache.org>.
bmscomp commented on code in PR #14075:
URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437161


##########
build.gradle:
##########
@@ -808,10 +809,9 @@ if (userEnableTestCoverage) {
     executionData.from = javaProjects.jacocoTestReport.executionData
 
     reports {
-      html.enabled = true
-      xml.enabled = true
+      xml.required = true

Review Comment:
   Tanks @ex172000  for the review, No reason to have a duplicate entry l will fix it now 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org