You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steve Rowe (JIRA)" <ji...@apache.org> on 2016/06/20 23:10:57 UTC
[jira] [Resolved] (SOLR-9229) TestNRTOpen.testSharedCores()
failures
[ https://issues.apache.org/jira/browse/SOLR-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Rowe resolved SOLR-9229.
------------------------------
Resolution: Fixed
Assignee: Steve Rowe
Fix Version/s: 5.5.2
These failures were caused because as part of the SOLR-8621 commit included in Solr 5.5.0, the {{solr.tests.mergePolicy}} sysprop (set by {{TestNRTOpen}} to {{org.apache.lucene.index.LogDocMergePolicy}}) was ignored in the {{solrconfig.snippet.randomindexconfig.xml}} included in {{solrconfig-basic.xml}}:
{noformat:title=SOLR-8621.patch against solrconfig.snippet.randomindexconfig.xml}
<!-- this sys property is not set by SolrTestCaseJ4 because we ideally want to use
the RandomMergePolicy in all tests - but some tests expect very specific
Merge behavior, so those tests can set it as needed.
-->
-->
- <mergePolicy class="${solr.tests.mergePolicy:org.apache.solr.util.RandomMergePolicy}" />
+ <mergePolicyFactory class="org.apache.solr.util.RandomMergePolicyFactory" />
{noformat}
This problem was rectified shortly thereafter by SOLR-8674 and committed to branch_5x, but never backported to branch_5_5 (note that SOLR-8621 didn't have to be backported to branch_5_5 because it was committed to branch_5x before branch_5_5 was created). Since SOLR-8674 isn't mentioned in {{CHANGES.txt}} at all, I failed to backport it to branch_5_5 in prepartion for the 5.5.2 release.
When I cherry-picked SOLR-8674 branch_5x commit onto branch_5_5, all of the above seeds started succeeding, so I'm resolving this issue as fixed.
> TestNRTOpen.testSharedCores() failures
> --------------------------------------
>
> Key: SOLR-9229
> URL: https://issues.apache.org/jira/browse/SOLR-9229
> Project: Solr
> Issue Type: Bug
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Fix For: 5.5.2
>
>
> My Jenkins found a reproducing TestNRTOpen.testSharedCores() failure on branch_5_5, and git bisect pointed the finger at SOLR-9034:
> {noformat}
> Checking out Revision c6b9ac065571718e7e92174fa7e2a927583012fa (refs/remotes/origin/branch_5_5)
> [...]
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestNRTOpen -Dtests.method=testSharedCores -Dtests.seed=7C31F56A2C49EB56 -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/lucene-data/enwiki.random.lines.txt -Dtests.locale=ar-LB -Dtests.timezone=Asia/Magadan -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> [junit4] FAILURE 0.21s J5 | TestNRTOpen.testSharedCores <<<
> [junit4] > Throwable #1: java.lang.AssertionError
> [junit4] > at __randomizedtesting.SeedInfo.seed([7C31F56A2C49EB56:9A32BF25A4BFC659]:0)
> [junit4] > at org.apache.solr.core.TestNRTOpen.testSharedCores(TestNRTOpen.java:117)
> [junit4] > at java.lang.Thread.run(Thread.java:745)
> {noformat}
> But Policeman Jenkins found another reproducing branch_5_5 seed [http://jenkins.thetaphi.de/job/Lucene-Solr-5.5-Linux/310/consoleText], and {{git bisect}} instead blames SOLR-8621:
> {noformat}
> Checking out Revision c6b9ac065571718e7e92174fa7e2a927583012fa (refs/remotes/origin/branch_5_5)
> [...]
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestNRTOpen -Dtests.method=testSharedCores -Dtests.seed=A2B2DA22BF73E3AF -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=es-HN -Dtests.timezone=Libya -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> [junit4] FAILURE 0.49s J1 | TestNRTOpen.testSharedCores <<<
> [junit4] > Throwable #1: java.lang.AssertionError: expected:<3> but was:<1>
> [junit4] > at __randomizedtesting.SeedInfo.seed([A2B2DA22BF73E3AF:44B1906D3785CEA0]:0)
> [junit4] > at org.apache.solr.core.TestNRTOpen.testSharedCores(TestNRTOpen.java:116)
> {noformat}
> And when I go back and look at Jenkins emails, the first modern failure for this test was just a couple hours after SOLR-8621 was committed [http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/15516/] - this reproduces for me on current branch_5_5:
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestNRTOpen -Dtests.method=testSharedCores -Dtests.seed=1A4EC986938AC08C -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=en-PH -Dtests.timezone=America/Cayman -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
> [junit4] FAILURE 0.31s J1 | TestNRTOpen.testSharedCores <<<
> [junit4] > Throwable #1: java.lang.AssertionError: expected:<3> but was:<1>
> [junit4] > at __randomizedtesting.SeedInfo.seed([1A4EC986938AC08C:FC4D83C91B7CED83]:0)
> [junit4] > at org.apache.solr.core.TestNRTOpen.testSharedCores(TestNRTOpen.java:116)
> {noformat}
> However, when the above seed fails on my box, the point at which the failure occurs as well as the cause are different from above:
> {noformat}
> [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestNRTOpen -Dtests.method=testSharedCores -Dtests.seed=1A4EC986938AC08C -Dtests.multiplier=3 -Dtests.slow=true -Dtests.linedocsfile=/home/jenkins/lucene-data/enwiki.random.lines.txt -Dtests.locale=en-PH -Dtests.timezone=America/Cayman -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
> [junit4] FAILURE 0.24s | TestNRTOpen.testSharedCores <<<
> [junit4] > Throwable #1: java.lang.AssertionError: expected:<[org.apache.lucene.index.SegmentCoreReaders@69824fe7, org.apache.lucene.index.SegmentCoreReaders@68a89668, org.apache.lucene.index.SegmentCoreReaders@488b9d9f]> but was:<[org.apache.lucene.index.SegmentCoreReaders@3829a0a0, org.apache.lucene.index.SegmentCoreReaders@69824fe7, org.apache.lucene.index.SegmentCoreReaders@68a89668]>
> [junit4] > at __randomizedtesting.SeedInfo.seed([1A4EC986938AC08C:FC4D83C91B7CED83]:0)
> [junit4] > at org.apache.solr.core.TestNRTOpen.testSharedCores(TestNRTOpen.java:124)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org