You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by XiaotaoYi <gi...@git.apache.org> on 2019/01/05 10:29:23 UTC
[GitHub] carbondata pull request #3052: [CARBONDATA-3227:There are some spell errors ...
GitHub user XiaotaoYi opened a pull request:
https://github.com/apache/carbondata/pull/3052
[CARBONDATA-3227:There are some spell errors in the project
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XiaotaoYi/carbondata xt-spell-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/3052.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3052
----
commit 51e7eecccb5ac3dbdbcc5a8089dea09b4ca708bf
Author: XiaotaoYi <v-...@...>
Date: 2019-01-05T10:18:37Z
CARBONDATA-3227:There are some spell errors in the project
----
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on the issue:
https://github.com/apache/carbondata/pull/3052
add to whitelist
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/3052
LGTM
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3052
LGTM! Thanks for you contribution!
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2420/
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10433/
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505760
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
@@ -796,10 +796,10 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
dictExcludeCols
.foreach { dictExcludeCol =>
if (!fields.exists(x => x.column.equalsIgnoreCase(dictExcludeCol))) {
- val errormsg = "DICTIONARY_EXCLUDE column: " + dictExcludeCol +
+ val errorMsg = "DICTIONARY_EXCLUDE column: " + dictExcludeCol +
" does not exist in table or unsupported for complex child column. " +
"Please check create table statement."
--- End diff --
```suggestion
"Please check the create table statement."
```
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505699
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
@@ -697,9 +697,9 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
tableProperties(CarbonCommonConstants.INVERTED_INDEX).split(',').map(_.trim)
invertedIdxColsProps.foreach { invertedIdxColProp =>
if (!fields.exists(x => x.column.equalsIgnoreCase(invertedIdxColProp))) {
- val errormsg = "INVERTED_INDEX column: " + invertedIdxColProp +
+ val errorMsg = "INVERTED_INDEX column: " + invertedIdxColProp +
" does not exist in table. Please check create table statement."
--- End diff --
```suggestion
" does not exist in table. Please check the create table statement."
```
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505691
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
@@ -668,9 +668,9 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
tableProperties(CarbonCommonConstants.NO_INVERTED_INDEX).split(',').map(_.trim)
noInvertedIdxColsProps.foreach { noInvertedIdxColProp =>
if (!fields.exists(x => x.column.equalsIgnoreCase(noInvertedIdxColProp))) {
- val errormsg = "NO_INVERTED_INDEX column: " + noInvertedIdxColProp +
+ val errorMsg = "NO_INVERTED_INDEX column: " + noInvertedIdxColProp +
" does not exist in table. Please check create table statement."
--- End diff --
```suggestion
" does not exist in table. Please check the create table statement."
```
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10460/
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505788
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
@@ -837,9 +837,9 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
// include cols should not contain exclude cols
dictExcludeCols.foreach { dicExcludeCol =>
if (dictIncludeCols.exists(x => x.equalsIgnoreCase(dicExcludeCol))) {
- val errormsg = "DICTIONARY_EXCLUDE can not contain the same column: " + dicExcludeCol +
+ val errorMsg = "DICTIONARY_EXCLUDE can not contain the same column: " + dicExcludeCol +
" with DICTIONARY_INCLUDE. Please check create table statement."
--- End diff --
```suggestion
" with DICTIONARY_INCLUDE. Please check the create table statement."
```
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...
Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245505775
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
@@ -821,10 +821,10 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
tableProperties(CarbonCommonConstants.DICTIONARY_INCLUDE).split(",").map(_.trim)
dictIncludeCols.foreach { distIncludeCol =>
if (!fields.exists(x => x.column.equalsIgnoreCase(distIncludeCol.trim))) {
- val errormsg = "DICTIONARY_INCLUDE column: " + distIncludeCol.trim +
+ val errorMsg = "DICTIONARY_INCLUDE column: " + distIncludeCol.trim +
" does not exist in table or unsupported for complex child column. " +
"Please check create table statement."
--- End diff --
```suggestion
"Please check the create table statement."
```
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...
Posted by XiaotaoYi <gi...@git.apache.org>.
Github user XiaotaoYi commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3052#discussion_r245512840
--- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala ---
@@ -668,9 +668,9 @@ abstract class CarbonDDLSqlParser extends AbstractCarbonSparkSQLParser {
tableProperties(CarbonCommonConstants.NO_INVERTED_INDEX).split(',').map(_.trim)
noInvertedIdxColsProps.foreach { noInvertedIdxColProp =>
if (!fields.exists(x => x.column.equalsIgnoreCase(noInvertedIdxColProp))) {
- val errormsg = "NO_INVERTED_INDEX column: " + noInvertedIdxColProp +
+ val errorMsg = "NO_INVERTED_INDEX column: " + noInvertedIdxColProp +
" does not exist in table. Please check create table statement."
--- End diff --
See commit 2
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2177/
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227:There are some spell errors in the ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Can one of the admins verify this patch?
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2203/
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3052
add to whitelist
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3052
@XiaotaoYi Please optimize the title, like: [CARBONDATA-3227] Fix some spell errors in the project
---
[GitHub] carbondata pull request #3052: [CARBONDATA-3227] Fix some spell errors in th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/3052
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by xubo245 <gi...@git.apache.org>.
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/3052
@XiaotaoYi Please fix the CI errors.
---
[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/3052
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2392/
---