[GitHub] [cordova-js] raphinesse opened a new pull request #205: Completely refactor build system

[GitBox <gi...@apache.org>]

raphinesse opened a new pull request #205: Completely refactor build system
URL: https://github.com/apache/cordova-js/pull/205
 
 
   
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   The goals of this refactoring are the following:
   
   - Improve code quality of the build system
   - Prepare code base for adding code coverage
   - Prepare code base for exposing the build system as a package export, so platforms can
     build their `cordova.js` during their build (or creation) process.
     This would make the JS build using coho obsolete.
   - Prepare code base to remove dependency on Grunt
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   The build process now lives under `build-tools` (was `tasks`). It does
   not depend on Grunt anymore but is written in plain Node.js.
   
   The original Grunt interface for building (as used by coho) was
   preserved and is implemented in `Gruntfile.js` using the new build
   system. The `platformName` option and support for getting platform paths
   from the `cordova-platforms` key in `package.json` have been removed
   from the Grunt interface, but neither of those are used in coho.
   
   The logic that is specific to the test build has been extracted from
   the rest of the build. It now lives in `test/build.js` and is run
   automatically during `npm test`.
   
   The following dependencies have been added:
   
   - execa
   - fs-extra
   - globby
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   I have taken extra care to preserve the exact format of the built file.
   This means that the correctness of the refactoring can be verified by
   simply diffing the build artifacts in `pkg` created with and without
   this change.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org