You are viewing a plain text version of this content. The canonical link for it is here.
Posted to distributedlog-dev@bookkeeper.apache.org by xiliuant <gi...@git.apache.org> on 2016/12/22 18:33:15 UTC
[GitHub] incubator-distributedlog pull request #89: DL-132: Enable check style for di...
GitHub user xiliuant opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/89
DL-132: Enable check style for distributedlog service module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiliuant/incubator-distributedlog xi/checkstyle_service
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 5bab9f384547c719e141557735cc14752e6d67a3
Author: Xi Liu <xi...@gmail.com>
Date: 2016-12-22T18:31:41Z
DL-132: Enable check style for distributedlog service module.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #89: DL-132: Enable check style for distribut...
Posted by xiliuant <gi...@git.apache.org>.
Github user xiliuant commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/89
@sijie @leighst I have rebased the pull request to latest master. please review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog pull request #89: DL-132: Enable check style for di...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-distributedlog/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #89: DL-132: Enable check style for distribut...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/89
@xiliuant looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-distributedlog issue #89: DL-132: Enable check style for distribut...
Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:
https://github.com/apache/incubator-distributedlog/pull/89
@xiliuant
I've done with the merges. Do you mind rebasing your change? So I can include this in 0.4.0.
/cc @leighst
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---