You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/23 21:52:14 UTC
[jira] [Commented] (CB-8214) COHO. Rename windowsphone to wp8 to be
consistent
[ https://issues.apache.org/jira/browse/CB-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257512#comment-14257512 ]
ASF GitHub Bot commented on CB-8214:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-coho/pull/60
CB-8214 COHO. Rename windowsphone to wp8 to be consistent
https://issues.apache.org/jira/browse/CB-8214
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho CB-8214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit 9ef187642bb45baa5781a714902d89dd5860ade2
Author: sgrebnov <v-...@microsoft.com>
Date: 2014-12-23T20:49:56Z
CB-8214 COHO. Rename windowsphone to wp8 to be consistent
----
> COHO. Rename windowsphone to wp8 to be consistent
> -------------------------------------------------
>
> Key: CB-8214
> URL: https://issues.apache.org/jira/browse/CB-8214
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Coho
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
>
> COHO currently uses windowsphone target name to refer wp8. For consistency reasons we should use wp8. Also, due to this it requires additional checks in code code to replace windowsphone string to wp8 to pass correct target platform name to other tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org