You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by "ZjuYTW (via GitHub)" <gi...@apache.org> on 2023/05/19 12:58:31 UTC

[PR] fix thrift version gt 0.13.0 (brpc)

ZjuYTW opened a new pull request, #2257:
URL: https://github.com/apache/brpc/pull/2257

   ### What problem does this PR solve?
   
   Issue Number: #1328 
   
   Problem Summary: 
   When using thrift version greater than 0.13.0, brpc can't compile correctly due to deprecate of boost.
   
   
   ### What is changed and the side effects?
   
   Changed:
   
   Now compile logic works as follow:
   For version < 0.11, set _THRIFT_VERSION_LOWER_THAN_0_11_0_ in cmake and using boost
   For 0.11 < version <= 0.13, _THRIFT_STDCXX_H_ is set inside thrift/stdcxx.h and use apache::thrift::stdcxx
   For later, just use std
   
   Side effects:
   - Performance effects(性能影响):
   No
   - Breaking backward compatibility(向后兼容性): 
   No, later version of thrift use std as well.
   ---
   ### Check List:
   - Please make sure your changes are compilable(请确保你的更改可以通过编译).
   - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
   - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "ZjuYTW (via GitHub)" <gi...@apache.org>.

ZjuYTW commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1557516521

   No so sure if I need to get bazel compatible for thrift >= 0.13, seems there is no enough doc about how to build by bazel...  
   And maybe later I should add some CI tests for thrift >= 0.13?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.

wwbmmm merged PR #2257:
URL: https://github.com/apache/brpc/pull/2257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "ZjuYTW (via GitHub)" <gi...@apache.org>.

ZjuYTW commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1554727690

   seems also need to address other two compile methods


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "ZjuYTW (via GitHub)" <gi...@apache.org>.

ZjuYTW commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1694193576

   > This PR has conflicts with master, please resolve @ZjuYTW
   
   done @wwbmmm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.

wwbmmm commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1698421667

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.

wwbmmm commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1680117469

   This PR has conflicts with master, please resolve @ZjuYTW 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.

wwbmmm commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1605906636

   Can you detect thrift version in cpp code? So that you will not depend on different compile methods.
   
   > 
   
   The bazel build use thrift 0.15.0 and CI is success. It seems that bazel build already supports thrift > 0.13.0 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "ZjuYTW (via GitHub)" <gi...@apache.org>.

ZjuYTW commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1705500187

   maybe we can merge it? @wwbmmm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

Re: [PR] fix thrift version gt 0.13.0 (brpc)

Posted by "ZjuYTW (via GitHub)" <gi...@apache.org>.

ZjuYTW commented on PR #2257:
URL: https://github.com/apache/brpc/pull/2257#issuecomment-1616457750

   > 
   
    In BUILD.bazel L44 says -DTHRIFT_STDCXX=std on default condition.
   
   so already compatible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org