[GitHub] eric-haibin-lin commented on a change in pull request #10696: [MXNET-366]Extend MXNet Distributed Training by AllReduce

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #10696: [MXNET-366]Extend MXNet Distributed Training by AllReduce
URL: https://github.com/apache/incubator-mxnet/pull/10696#discussion_r199403125
 
 

 ##########
 File path: src/kvstore/kvstore_dist_sync_allreduce.h
 ##########
 @@ -0,0 +1,262 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Copyright (c) 2018 by Contributors
+ * @file   kvstore_dist_sync_allreduce.h
+ * @brief  distributed implementation based on allreduce
+ */
+#ifndef MXNET_KVSTORE_KVSTORE_DIST_SYNC_ALLREDUCE_H_
+#define MXNET_KVSTORE_KVSTORE_DIST_SYNC_ALLREDUCE_H_
+
+#include <mxnet/kvstore.h>
+#include <unordered_map>
+#include <bitset>
+#include <vector>
+#include <string>
+#include <utility>
+#include <functional>
+#include <algorithm>
+#include "./comm.h"
+#include "./kvstore_utils.h"
+#include "./kvstore_local.h"
+
+#if MXNET_USE_ALLREDUCE_DIST_KVSTORE
+#include "collectives/include/collectives.h"
+
+namespace mxnet {
+namespace kvstore {
+
+/**
+ * \brief store data in local machine
+ */
+class KVStoreDistSyncAllReduce : public KVStoreLocal {
+ public:
+  explicit KVStoreDistSyncAllReduce(bool use_device_comm)
+  : KVStoreLocal(use_device_comm) {
+    int ret = MXCOLLIBInit(comm_);
+    if (ret != 0) {
+      LOG(FATAL) << "kvstore with type [" << type_ << "] failed with collective library init";
+    }
+  }
+
+  virtual ~KVStoreDistSyncAllReduce() {
+  }
+
+  void Push(const std::vector<int>& keys,
+            const std::vector<NDArray>& values,
+            int priority) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void Pull(const std::vector<int>& keys,
+            const std::vector<NDArray*>& values,
+            int priority) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void PullRowSparse(const std::vector<int>& keys,
+                     const std::vector<std::pair<NDArray*, NDArray>>& val_rowids,
+                     int priority = 0) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void Push(const std::vector<std::string>& str_keys,
+            const std::vector<NDArray>& values,
+            int priority) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void Pull(const std::vector<std::string>& str_keys,
+            const std::vector<NDArray*>& values,
+            int priority) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void PullRowSparse(const std::vector<std::string>& str_keys,
+                     const std::vector<std::pair<NDArray*, NDArray>>& val_rowids,
+                     int priority = 0) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void SetGradientCompression(const std::vector<std::pair<std::string, std::string> >
+                              & kwargs) override {
+    LOG(WARNING) << "Not supported in KVStore with type " << type_ << ".";
+  }
+
+  void PushPull(const std::vector<int> &keys,
+                const std::vector<NDArray> &in_values,
+                const std::vector<NDArray*> &out_values,
+                int priority) override {
+    SetKeyType(kIntKey);
+    PushPullImpl(keys, in_values, out_values, priority);
+  }
+
+  void PushPull(const std::vector<std::string> &str_keys,
+                const std::vector<NDArray> &in_values,
+                const std::vector<NDArray*> &out_values,
+                int priority) override {
+    SetKeyType(kStringKey);
+    std::vector<int> keys(str_keys.size());
+    LookupKeys(str_keys, &keys);
+    PushPullImpl(keys, in_values, out_values, priority);
+  }
+
+  void Broadcast(const std::vector<int> &keys,
+                 const std::vector<NDArray*> &values,
+                 int root_rank,
+                 int priority) override {
+    SetKeyType(kIntKey);
+    BroadcastImpl(keys, values, root_rank, priority);
+  }
+
+  void Broadcast(const std::vector<std::string> &str_keys,
+                 const std::vector<NDArray*> &values,
+                 int root_rank,
+                 int priority) override {
+    SetKeyType(kStringKey);
+    std::vector<int> keys(str_keys.size());
+    LookupKeys(str_keys, &keys);
+    BroadcastImpl(keys, values, root_rank, priority);
+  }
+
+  void Barrier() override {
+    int ret = MXBarrier();
 
 Review comment:
   Does dist allreduce support `kv._barrier`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services