You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by se...@apache.org on 2016/11/28 17:31:45 UTC

[2/2] flink git commit: [FLINK-5142] [checkpoints] Fix timer resource leak in CheckpointCoordinator

[FLINK-5142] [checkpoints] Fix timer resource leak in CheckpointCoordinator


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/e2c53cf8
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/e2c53cf8
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/e2c53cf8

Branch: refs/heads/release-1.1
Commit: e2c53cf85c1af73c040d96dbd24b9e2cf3e8cdf6
Parents: ca90809
Author: Stephan Ewen <se...@apache.org>
Authored: Mon Nov 28 15:13:35 2016 +0100
Committer: Stephan Ewen <se...@apache.org>
Committed: Mon Nov 28 15:13:35 2016 +0100

----------------------------------------------------------------------
 .../apache/flink/runtime/checkpoint/CheckpointCoordinator.java  | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/e2c53cf8/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
index 6e7b4b9..0cf944c 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
@@ -421,10 +421,9 @@ public class CheckpointCoordinator {
 			if (lastTriggeredCheckpoint + minPauseBetweenCheckpoints > timestamp && baseInterval != Long.MAX_VALUE) {
 				if (currentPeriodicTrigger != null) {
 					currentPeriodicTrigger.cancel();
-					currentPeriodicTrigger = null;
 				}
-				ScheduledTrigger trigger = new ScheduledTrigger();
-				timer.scheduleAtFixedRate(trigger, minPauseBetweenCheckpoints, baseInterval);
+				currentPeriodicTrigger = new ScheduledTrigger();
+				timer.scheduleAtFixedRate(currentPeriodicTrigger, minPauseBetweenCheckpoints, baseInterval);
 				return false;
 			}
 		}