[GitHub] [spark] srowen edited a comment on pull request #28769: [SPARK-31929][WEBUI] Close leveldbiterator when leveldb.close

[GitBox <gi...@apache.org>]

srowen edited a comment on pull request #28769:
URL: https://github.com/apache/spark/pull/28769#issuecomment-906733567


   Ah, OK. WeakReference indeed gets cleared on non-full GCs. So WeakReference would potentially hold on to the references but not prevent them from being GCed by small GC collections, as before. This tracker then doesn't do a _whole_ lot - only catches things that weren't closed correctly, and only things that weren't closed by the time the LevelDB is closed, and before a GC. Still, if finalize() is going to catch the close() on GC then yeah we don't want to delay the collection. I'd agree with that small tweak.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org