You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "AyushS1304 (via GitHub)" <gi...@apache.org> on 2026/07/31 19:59:31 UTC
[PR] fix(pr-management-triage): centralize terminal PR links [magpie]
AyushS1304 opened a new pull request, #1049:
URL: https://github.com/apache/magpie/pull/1049
<!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 -->
## Summary
- Add one formatter for short and full GitHub pull-request references, resolving each to a canonical `/pull/<number>` URL.
- Emit OSC 8 terminal hyperlinks when supported, with readable URL fallbacks for `NO_COLOR`, `TERM=dumb`, and non-terminal output.
- Apply the renderer consistently across triage progress, proposals, grouped results, drill-down views, errors, and summaries, with regression fixtures for each fallback path.
## Type of change
- [x] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
- [ ] Tool / bridge contract (`tools/<system>/*.md`)
- [ ] Python package (`tools/*/` with `pyproject.toml`)
- [ ] Groovy reference impl
- [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
- [x] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [ ] Project template (`projects/_template/`)
- [ ] CI / dev loop (`prek`, workflows, validators)
- [x] Other: triage CLI helper and unit tests
## Test plan
- [x] `prek run --all-files` passes
- [x] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
- [ ] For Groovy bridges touched: command-line invocation tested end-to-end
- [x] For skill changes: eval suite passes for the affected skill
- [x] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
- [x] Other: 9 helper unit tests and all 150 skill-eval framework tests pass
## RFC-AI-0004 compliance
- [ ] **HITL** — any new mutation is gated on explicit user confirmation
- [ ] **Sandbox** — no new unrestricted host access; network reach declared in the adapter
- [x] **Vendor neutrality** — placeholders used in skill and tool prose
- [ ] **Conversational + correctable** — agentic-override path documented if behaviour is adopter-tunable
- [ ] **Write-access discipline** — no autonomous outbound messages; drafts only, sent on confirmation
- [ ] **Privacy LLM** — private content does not reach a non-approved LLM; redactor invoked where needed
# Ai Assistance
took help from Codex for testing.
## Linked issues
Closes #73
## Notes for reviewers
The helper deliberately keeps the visible reference compact in capable terminals while ensuring the canonical URL remains visible everywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pr-management-triage): centralize terminal PR links [magpie]
Posted by "AyushS1304 (via GitHub)" <gi...@apache.org>.
AyushS1304 commented on PR #1049:
URL: https://github.com/apache/magpie/pull/1049#issuecomment-5153049140
Thanks for the detailed review and for merging this. The `skills/**` CI gap is a great catch. I saw #1053 and #1054 cover the broader fix, including the stale `noqa`. Appreciate you tracing it through and wiring the checks up properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pr-management-triage): centralize terminal PR links [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #1049:
URL: https://github.com/apache/magpie/pull/1049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org