You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/23 16:29:50 UTC
[GitHub] [bookkeeper] pgier opened a new pull request, #3715: [improve][doc] improve bk_server.conf docs
pgier opened a new pull request, #3715:
URL: https://github.com/apache/bookkeeper/pull/3715
Add default value of `allowMultipleDirsUnderSameDiskPartition`
Signed-off-by: Paul Gier <pa...@datastax.com>
Descriptions of the changes in this PR:
### Motivation
Just a minor doc fix
### Changes
Updated the bk_server.conf and the website config doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on a diff in pull request #3715: [improve][doc] improve bk_server.conf docs
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on code in PR #3715:
URL: https://github.com/apache/bookkeeper/pull/3715#discussion_r1056641167
##########
conf/bk_server.conf:
##########
@@ -41,7 +41,8 @@
bookiePort=3181
# Configure the bookie to allow/disallow multiple ledger/index/journal directories
-# in the same filesystem disk partition
+# in the same filesystem disk partition.
+# Defaults to true.
# allowMultipleDirsUnderSameDiskPartition=false
Review Comment:
Can you change also this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pgier commented on a diff in pull request #3715: [improve][doc] improve bk_server.conf docs
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #3715:
URL: https://github.com/apache/bookkeeper/pull/3715#discussion_r1058526560
##########
conf/bk_server.conf:
##########
@@ -41,7 +41,8 @@
bookiePort=3181
# Configure the bookie to allow/disallow multiple ledger/index/journal directories
-# in the same filesystem disk partition
+# in the same filesystem disk partition.
+# Defaults to true.
# allowMultipleDirsUnderSameDiskPartition=false
Review Comment:
@nicoloboschi I updated the example config to match the default `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi merged pull request #3715: [improve][doc] improve bk_server.conf docs
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #3715:
URL: https://github.com/apache/bookkeeper/pull/3715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pgier commented on a diff in pull request #3715: [improve][doc] improve bk_server.conf docs
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #3715:
URL: https://github.com/apache/bookkeeper/pull/3715#discussion_r1056986345
##########
conf/bk_server.conf:
##########
@@ -41,7 +41,8 @@
bookiePort=3181
# Configure the bookie to allow/disallow multiple ledger/index/journal directories
-# in the same filesystem disk partition
+# in the same filesystem disk partition.
+# Defaults to true.
# allowMultipleDirsUnderSameDiskPartition=false
Review Comment:
@eolivelli I thought that wouldn't affect the default value since it's commented out? Wouldn't it still default to true based on the [sources](https://github.com/apache/bookkeeper/blob/032aef7e75f6b3487a6611a2b8af8306b9a3f7bb/bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java#L3499-L3500).
I wasn't sure if the commented out examples were supposed to match the default values, or were to there to provide an each way to uncomment and override the default value. I think there are examples of both cases currently in the config file. Setting it to match the default value as @nicoloboschi suggested does seem a bit more intuitive to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3715: [improve][doc] improve bk_server.conf docs
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3715:
URL: https://github.com/apache/bookkeeper/pull/3715#discussion_r1056979101
##########
conf/bk_server.conf:
##########
@@ -41,7 +41,8 @@
bookiePort=3181
# Configure the bookie to allow/disallow multiple ledger/index/journal directories
-# in the same filesystem disk partition
+# in the same filesystem disk partition.
+# Defaults to true.
# allowMultipleDirsUnderSameDiskPartition=false
Review Comment:
If we change this value then we will change the default behaviour
@RaulGracia please also take a look. I think that in Pravega we rely on this file for default values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org