You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/19 14:17:48 UTC
[PR] fix(message): parse CR-separated properties [rocketmq-dashboard]
Loyal-Young opened a new pull request, #7107:
URL: https://github.com/apache/rocketmq-dashboard/pull/7107
## Summary
- Parse CR-only as well as CRLF and LF line breaks in bulk message-property input.
- Preserve existing handling of additional equals signs inside property values.
- Add a mixed-newline regression test.
Fixes #7106.
## Verification
- `npm test -- --run src/utils/messageProperties.test.ts`: 5 passed.
- ESLint and Prettier checks passed for both changed files.
- `git diff --check` passed.
## AI assistance
I used AI assistance to identify the CR-only parsing gap and draft the regression case. I reviewed the patch and ran the focused frontend checks locally; I will follow up on CI and review feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(message): parse CR-separated properties [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #7107:
URL: https://github.com/apache/rocketmq-dashboard/pull/7107#issuecomment-6285769727
CI update: the Frontend Build failure is in ConsumerPage.test.tsx (the two modal refresh/stack assertions), outside this PR's message-property parser and test. The same real-timer race is documented with a pending test-only fix in #5626. The focused messageProperties.test.ts check passed locally (5/5); I will recheck CI after the shared test fix lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(message): parse CR-separated properties [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #7107:
URL: https://github.com/apache/rocketmq-dashboard/pull/7107#issuecomment-6417156043
Closing as a duplicate of #7121 (still open): the two are semantically identical, and #7121 sits on base 127c47b06 with the explanatory comment we want in the tree. Thank you for the careful test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(message): parse CR-separated properties [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #7107: fix(message): parse CR-separated properties
URL: https://github.com/apache/rocketmq-dashboard/pull/7107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org