You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/30 13:34:04 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #16166: Fixing SES backend - source (mail_from) must be string.

mik-laj commented on a change in pull request #16166:
URL: https://github.com/apache/airflow/pull/16166#discussion_r642077671



##########
File path: airflow/providers/amazon/aws/utils/emailer.py
##########
@@ -36,8 +37,10 @@ def send_email(
 ) -> None:
     """Email backend for SES."""
     hook = SESHook(aws_conn_id=conn_id)
+    
+    mail_from = conf.get('smtp', 'SMTP_MAIL_FROM')

Review comment:
       It looks good. Can you add tests to avoid regression?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org