[jira] [Commented] (PHOENIX-6151) Switch phoenix-client to shade-by-default mode

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199990#comment-17199990 ] 

Istvan Toth commented on PHOENIX-6151:
--------------------------------------

I've linked the draft PR for this.

Basically, I have copied the shading settings from Hadoop, excluded Hbase and Phoenix,

and set up additional relocations and filters for phoenix-specific stuff.

 

I have run a quick smoke test on it, and it seems to work.

 

One known problem is that this breaks phoenix-queryserver-it, as the shading seems to conflict with the minicluster dependencies.

 

I have also tried to shade Hadoop and Hbase as well, but this resulted in the JDBC driver not getting registered. I did not debug that case yet.

 

> Switch phoenix-client to shade-by-default mode
> ----------------------------------------------
>
>                 Key: PHOENIX-6151
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6151
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 5.1.0, 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Phoenix-client contains Phoenix, plus most of a Hadoop+Hbase stack.
> We keep running into difficulties, where phoenix-client conflicts with user code, or in the case of connectors with different components.
> Instead of shading packages explicitly, try the approach of shading everything, and only keeping unshaded the libraries that cannot be shaded.
> This is the approach taken by Hadoop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)