You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/04/29 21:35:31 UTC

[GitHub] [openmeetings] sebawagner commented on a change in pull request #71: OPENMEETINGS-2315 Only StreamProcessor to hold reference of KStream

sebawagner commented on a change in pull request #71:
URL: https://github.com/apache/openmeetings/pull/71#discussion_r417626523



##########
File path: openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
##########
@@ -118,21 +123,6 @@ public void onStopBroadcast(KStream stream, final StreamProcessor processor) {
 		//FIXME TODO permission can be removed, some listener might be required
 	}
 
-	public void leave(final StreamProcessor processor, final Client c) {

Review comment:
       We don't need this method anymore. It would lead to circular reference otherwise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org