You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/19 13:05:00 UTC
[jira] [Commented] (FLINK-8959) Port AccumulatorLiveITCase to flip6

    [ https://issues.apache.org/jira/browse/FLINK-8959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404779#comment-16404779 ] 

ASF GitHub Bot commented on FLINK-8959:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5719

    [FLINK-8959][tests] Port AccumulatorLiveITCase to flip6 

    Based on #5701.
    
    ## What is the purpose of the change
    
    This PR ports the `AccumulatorLiveITCase` to flip6. The existing test was renamed to `LegacyAccumulatorLiveITCase`, and a ported copy was added.
    
    The heartbeat interval is not configurable for legacy clusters and is hard-coded to 5 seconds. Porting this test (in a reliable fashion) without relying on internal/test APIs would've increased the test duration, so I decided to just leave it as it is.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8959

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5719
    
----
commit c676e2895f9adcaaddc30f12a7378ce5d6089fd6
Author: zentol <ch...@...>
Date:   2018-03-14T13:21:27Z

    [FLINK-8942][runtime] Pass heartbeat target ResourceID

commit 5858766794f81bd111a6380ef729a9c91b4b9ced
Author: zentol <ch...@...>
Date:   2018-03-14T17:52:16Z

    [FLINK-8881][runtime] Send accumulator updates via heartbeats

commit 040c8d053501e4aba609efc9757905cd6b553ecb
Author: zentol <ch...@...>
Date:   2018-03-07T10:05:42Z

    [FLINK-8935][tests] Implement MiniClusterClient#getAccumulators

commit 84b686146d5f7176e6c1dcec9bbdf51b9c601457
Author: zentol <ch...@...>
Date:   2018-03-19T12:59:22Z

    [FLINK-8959][tests] Port AccumulatorLiveITCase to flip6

----


> Port AccumulatorLiveITCase to flip6
> -----------------------------------
>
>                 Key: FLINK-8959
>                 URL: https://issues.apache.org/jira/browse/FLINK-8959
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)