You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2013/06/20 23:49:57 UTC

[1/2] git commit: [CB-3680] - fixed up plugin.xml for android and references

Updated Branches:
  refs/heads/master 9477b856c -> 603dc428d


[CB-3680] - fixed up plugin.xml for android and references


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/bfe59ee1
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/bfe59ee1
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/bfe59ee1

Branch: refs/heads/master
Commit: bfe59ee1e6a972b4e5622a59fb4a265f76e448fd
Parents: 9477b85
Author: Tim Kim <ti...@adobe.com>
Authored: Thu Jun 20 14:49:03 2013 -0700
Committer: Tim Kim <ti...@adobe.com>
Committed: Thu Jun 20 14:49:03 2013 -0700

----------------------------------------------------------------------
 plugin.xml     | 10 ++++++++--
 www/Contact.js |  2 +-
 2 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/bfe59ee1/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 80154a7..4e2b6f6 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -44,10 +44,16 @@ id="org.apache.cordova.core.contacts">
     <platform name="android">
         <config-file target="res/xml/config.xml" parent="/*">
             <feature name="Contacts">
-                <param name="android-package" value="org.apache.cordova.core.contacts.ContactManager"/>
+                <param name="android-package" value="org.apache.cordova.core.ContactManager"/>
             </feature>
         </config-file>
-
+        
+        <config-file target="AndroidManifest.xml" parent="/*">
+            <uses-permission android:name="android.permission.READ_CONTACTS" />
+            <uses-permission android:name="android.permission.WRITE_CONTACTS" />  
+            <uses-permission android:name="android.permission.GET_ACCOUNTS" />
+        </config-file>
+        
         <source-file src="src/android/ContactAccessor.java" target-dir="src/org/apache/cordova/core" />
         <source-file src="src/android/ContactAccessorSdk5.java" target-dir="src/org/apache/cordova/core" />
         <source-file src="src/android/ContactManager.java" target-dir="src/org/apache/cordova/core" />

http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/bfe59ee1/www/Contact.js
----------------------------------------------------------------------
diff --git a/www/Contact.js b/www/Contact.js
index 20ca863..72e4840 100644
--- a/www/Contact.js
+++ b/www/Contact.js
@@ -160,7 +160,7 @@ Contact.prototype.save = function(successCB, errorCB) {
     var success = function(result) {
         if (result) {
             if (successCB) {
-                var fullContact = require('cordova/plugin/contacts').create(result);
+                var fullContact = require('org.apache.cordova.core.contacts.contacts').create(result);
                 successCB(convertIn(fullContact));
             }
         }


[2/2] git commit: [CB-3681] - fixed small reference for ios

Posted by ti...@apache.org.
[CB-3681] - fixed small reference for ios


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/commit/603dc428
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/tree/603dc428
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/diff/603dc428

Branch: refs/heads/master
Commit: 603dc428d455979699544d7e72e8b350755c7943
Parents: bfe59ee
Author: Tim Kim <ti...@adobe.com>
Authored: Thu Jun 20 14:49:53 2013 -0700
Committer: Tim Kim <ti...@adobe.com>
Committed: Thu Jun 20 14:49:53 2013 -0700

----------------------------------------------------------------------
 www/ios/contacts.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-contacts/blob/603dc428/www/ios/contacts.js
----------------------------------------------------------------------
diff --git a/www/ios/contacts.js b/www/ios/contacts.js
index 09e0696..9a1438a 100644
--- a/www/ios/contacts.js
+++ b/www/ios/contacts.js
@@ -54,7 +54,7 @@ module.exports = {
          *
          */
          var win = function(result) {
-             var fullContact = require('cordova/plugin/contacts').create(result);
+             var fullContact = require('org.apache.cordova.core.contacts.contacts').create(result);
             successCallback(fullContact.id, fullContact);
        };
         exec(win, null, "Contacts","chooseContact", [options]);