[GitHub] [doris] zhiqiang-hhhh opened a new issue, #23216: [Bug] return value of RuntimeFilterMergeController::add_entity is not checked

["zhiqiang-hhhh (via GitHub)" <gi...@apache.org>]

zhiqiang-hhhh opened a new issue, #23216:
URL: https://github.com/apache/doris/issues/23216

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Version
   
   2.0
   
   ### What's Wrong?
   
   2.0 
   ```cpp
   Status FragmentMgr::exec_plan_fragment(const TPipelineFragmentParams& params,
                                          const FinishCallback& cb) {
       ...
       auto pre_and_submit = [&](int i) {
           ...
           _runtimefilter_controller.add_entity(params, local_params, &handler,
                                                context->get_runtime_state());
       }
   }
   
   
   Status RuntimeFilterMergeController::add_entity(...) {
       ....
       if (iter == _filter_controller_map[shard].end()) {
           ....
           RETURN_IF_ERROR(handle->get()->init(query_id, fragment_instance_id, filter_params,
                                               params.query_options));
       }
   }
   ```
   result of RuntimeFilterMergeController::add_entity is not checked when we handle fragment,  and if we add code like
   ```cpp
   RETURN_IF_ERROR (
           _runtimefilter_controller.add_entity(params, local_params, &handler,
                                                context->get_runtime_state());
   );
   ```
   will make regression test failed. 
   
   There must be something wrong aroud here.
   
   ### What You Expected?
   
   Every return value is checked.
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

Re: [I] [Bug] return value of RuntimeFilterMergeController::add_entity is not checked [doris]

["zhiqiang-hhhh (via GitHub)" <gi...@apache.org>]

zhiqiang-hhhh closed issue #23216: [Bug] return value of RuntimeFilterMergeController::add_entity is not checked
URL: https://github.com/apache/doris/issues/23216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org