You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/06/28 06:02:56 UTC

[GitHub] [arrow] kou commented on a diff in pull request #36344: GH-26153: [C++] Share common codes for RecordBatchStreamReader and StreamDecoder

kou commented on code in PR #36344:
URL: https://github.com/apache/arrow/pull/36344#discussion_r1244724170


##########
cpp/src/arrow/ipc/reader.h:
##########
@@ -301,9 +323,39 @@ class ARROW_EXPORT CollectListener : public Listener {
     return record_batches_;
   }
 
+  /// \return the all decoded metadatas
+  std::vector<std::shared_ptr<KeyValueMetadata>> metadatas() const { return metadatas_; }

Review Comment:
   We may want to use better name for a vector of metadata...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org