You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dbtsai <gi...@git.apache.org> on 2016/04/11 10:46:54 UTC
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/12298
[SPARK-14462][ML][MLLIB] Add the mllib-local build to maven pom
## What changes were proposed in this pull request?
In order to separate the linear algebra, and vector matrix classes into a standalone jar, we need to setup the build first. This PR will create a new jar called mllib-local with minimal dependencies.
The previous PR was failing the build because of `spark-core:test` dependency, and that was reverted. In this PR, `FunSuite` with `// scalastyle:ignore funsuite` in mllib-local test was used, similar to sketch.
Thanks.
## How was this patch tested?
Unit tests
@mengxr @tedyu @holdenk
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dbtsai/spark dbtsai-mllib-local-build-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12298
----
commit 46e58da1489b0ed41784044a0738089bf7364d29
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-06T21:38:10Z
add the mllib-local build to maven pom
Fix MiMa
Addressed some of feedback
Modifying sparktestsupport/modules.py for build server
fix a bug
Fix the build
Ignore org.apache.spark.SparkException from MiMa
commit 0e8a6090b54885a81dcf59b65ae35fc4e531176b
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-08T20:34:15Z
revert
commit edbd874123880c2e123080ebdb8201ef70337b3c
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-08T20:34:33Z
Merge branch 'master' into dbtsai-mllib-local-build
commit aa37a642ed130085bc579d320e6b905fee4e689e
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-08T22:21:10Z
address feedback
commit 4b49bac976d98f82da7005c9e6b11505c0255c01
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-08T22:24:36Z
formating
commit 86a3ba17e8a785f77e088ce444b5149f437ef4ae
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-08T22:24:56Z
remove unneeded ProblemFilters.exclude[MissingClassProblem]
commit fd358f98146f628b2d9c21d70caf7dcf885ba2a2
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-08T22:27:24Z
scala style
commit eba1e4d1624f0be3c5d463b92fecf2b8a8134000
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-09T02:58:48Z
Add back mllib dep
commit 4d6e394ae36044b97389d47d2b9dfcdbbfefde52
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-09T03:06:01Z
formating
commit ec033701d0740f9633c601354123aafe7b4fb942
Author: DB Tsai <db...@netflix.com>
Date: 2016-04-11T08:37:40Z
Fix the build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12298#issuecomment-208278993
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55518/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12298#issuecomment-208234643
**[Test build #55518 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55518/consoleFull)** for PR 12298 at commit [`ec03370`](https://github.com/apache/spark/commit/ec033701d0740f9633c601354123aafe7b4fb942).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/12298#issuecomment-208438237
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12298#issuecomment-208278760
**[Test build #55518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55518/consoleFull)** for PR 12298 at commit [`ec03370`](https://github.com/apache/spark/commit/ec033701d0740f9633c601354123aafe7b4fb942).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class DummyTestingSuite extends FunSuite `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14462][ML][MLLIB] Add the mllib-local b...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12298#issuecomment-208278992
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org