[GitHub] [ozone] jojochuang commented on a diff in pull request #3488: HDDS-6840. Adding more information to the OM and SCM UI-Page.

[GitBox <gi...@apache.org>]

jojochuang commented on code in PR #3488:
URL: https://github.com/apache/ozone/pull/3488#discussion_r891731188


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMXBean.java:
##########
@@ -28,4 +28,9 @@
 public interface OMMXBean extends ServiceRuntimeInfo {
 
   String getRpcPort();
+
+  String getOmRatisLogDirectory();
+
+  String getOmRocksDbDirectory();

Review Comment:
   ```suggestion
     String getRatisLogDirectory();
   
     String getRocksDbDirectory();
   ```



##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMMXBean.java:
##########
@@ -80,4 +80,7 @@ public interface SCMMXBean extends ServiceRuntimeInfo {
    */
   String getPrimordialNode();
 
+  String getScmRatisLogDirectory();
+
+  String getScmRocksDbDirectory();

Review Comment:
   suggest to drop the word "Scm" because everything in this MXBean is for SCM. It's redundant.
   ```suggestion
     String getRatisLogDirectory();
   
     String getRocksDbDirectory();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org