You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by GitBox <gi...@apache.org> on 2022/12/22 13:35:27 UTC

[GitHub] [opennlp] rzo1 commented on pull request #329: OPENNLP-1214: use hash to avoid linear search in DefaultEndOfSentence…

rzo1 commented on PR #329:
URL: https://github.com/apache/opennlp/pull/329#issuecomment-1362847889

   Perhaps we would need to write some **JMH** benchmarks to see any performance impacts / drawbacks. Using ` System.currentTimeMillis()` has its own drawbacks if used for benchmarking.
   
   If this is still a concern, we should write some **JMH** benchmarks to see, if there is a real difference (aside from JVM quirks / optimizations). Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org