You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/12/23 07:27:58 UTC
[GitHub] [dubbo] codecov-io commented on issue #5139: [Dubbo-4991] Fix zk client create logic

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=h1) Report
> Merging [#5139](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/a9746a0ae4f35948442b7d4de889ed3b91e339fe?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `93.33%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5139/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             master   #5139     +/-   ##
==========================================
- Coverage      61.3%   61.2%   -0.1%     
+ Complexity      427     423      -4     
==========================================
  Files           919     919             
  Lines         37487   37502     +15     
  Branches       5461    5465      +4     
==========================================
- Hits          22980   22954     -26     
- Misses        12003   12037     +34     
- Partials       2504    2511      +7
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ookeeper/support/AbstractZookeeperTransporter.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvc3VwcG9ydC9BYnN0cmFjdFpvb2tlZXBlclRyYW5zcG9ydGVyLmphdmE=) | `74.54% <93.33%> (+7.04%)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/dubbo/remoting/utils/PayloadDropper.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy91dGlscy9QYXlsb2FkRHJvcHBlci5qYXZh) | `46.15% <0%> (-23.08%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==) | `70.83% <0%> (-8.34%)` | `0% <0%> (ø)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0%> (-7.96%)` | `19% <0%> (-2%)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `65.45% <0%> (-7.28%)` | `0% <0%> (ø)` | |
| [...he/dubbo/common/threadpool/ThreadlessExecutor.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9UaHJlYWRsZXNzRXhlY3V0b3IuamF2YQ==) | `55.55% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `47.82% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `53.75% <0%> (-3.75%)` | `0% <0%> (ø)` | |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `70.17% <0%> (-3.51%)` | `8% <0%> (-1%)` | |
| [...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvcmVzdC9SZXN0UHJvdG9jb2wuamF2YQ==) | `68.21% <0%> (-3.11%)` | `0% <0%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/dubbo/pull/5139/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=footer). Last update [a9746a0...dcade6b](https://codecov.io/gh/apache/dubbo/pull/5139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5139 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org