You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/03 10:16:33 UTC

[GitHub] [incubator-seatunnel] zixi0825 opened a new issue #932: [Feature][plugin] unify the format of parameters in plugins

zixi0825 opened a new issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932


   ### Search before asking
   
   - [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
   
   
   ### Description
   
   Now I find that the formats of parameters in our plugins are quite diverse，the formats as follow : 
   - producer.bootstrap.servers
   - batch_size
   - customUpdateStmt
   
   I think we should unify the format of parameters in plugins, and wo can choose a format from follow
   
   1. batch.size
   2. batch_size
   3. batchSize
   
   And everyone can vote and choose the appropriate format 
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] huangxianxin commented on issue #932: [Discuss][plugin] unify the format of parameters in plugins

Posted by GitBox <gi...@apache.org>.
huangxianxin commented on issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932#issuecomment-1005410402


   I very much agree with you, and I prefer to use the second one, ( batch_size)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] YangCH0915 commented on issue #932: [Discuss][plugin] unify the format of parameters in plugins

Posted by GitBox <gi...@apache.org>.
YangCH0915 commented on issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932#issuecomment-1005451555


   Get used to the second one，( batch_size)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] yx91490 commented on issue #932: [Discuss][plugin] unify the format of parameters in plugins

Posted by GitBox <gi...@apache.org>.
yx91490 commented on issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932#issuecomment-1004471763


   I approve your suggestion, but better to keep backward compatibility when make adjustments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] leo65535 commented on issue #932: [Discuss][plugin] unify the format of parameters in plugins

Posted by GitBox <gi...@apache.org>.
leo65535 commented on issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932#issuecomment-1006419005


   Prefer to `producer.bootstrap.servers` 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on issue #932: [Discuss][plugin] unify the format of parameters in plugins

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932#issuecomment-1005408376


   I very much agree with you, and I prefer to use the second one. If everyone is sure later, I suggest that the plug-in configuration submitted in the current version can be reformatted again. (The old version is temporarily not used)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] zixi0825 commented on issue #932: [Discuss][plugin] unify the format of parameters in plugins

Posted by GitBox <gi...@apache.org>.
zixi0825 commented on issue #932:
URL: https://github.com/apache/incubator-seatunnel/issues/932#issuecomment-1013595030


   I think the first format will be better. At present, most connector parameters use the first format. We can use this format with less conversion and more general and mainstream. So I prefer to first one (producer.bootstrap.servers).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org