You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/17 12:35:30 UTC

[GitHub] [ignite] zstan commented on a change in pull request #9416: IGNITE-15526 Calcite. Incorrect grouping reset during rewind

zstan commented on a change in pull request #9416:
URL: https://github.com/apache/ignite/pull/9416#discussion_r711017577



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/HashAggregateNode.java
##########
@@ -239,6 +239,13 @@ private Grouping(byte grpId, ImmutableBitSet grpFields) {
 
             handler = context().rowHandler();
 
+            reset();

Review comment:
       my feeling of beauty tells me that it`s not elegant to clean the map on constructor ) can you change it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org