You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/14 09:12:32 UTC

[GitHub] [rocketmq] cserwen opened a new issue, #4606: Trace for LitePullConsumer may not work correctly

cserwen opened a new issue, #4606:
URL: https://github.com/apache/rocketmq/issues/4606

   **BUG REPORT**
   
   1. Please describe the issue you observed:
   Trace message are built when PullTaskImpl finishes executing.
   https://github.com/apache/rocketmq/blob/b136f9bb6725867dcc5d00798addd0de7382ffb3/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java#L952
   
   But in fact the message is only stored in the local cache, and only when `poll()` is called, the user's program will actually consume the messages, so I think the traces message should be built in `poll()`
   https://github.com/apache/rocketmq/blob/b136f9bb6725867dcc5d00798addd0de7382ffb3/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java#L542
   
   Will there be any problem with the implementation here? @zhangjidi2016 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] cserwen commented on issue #4606: Trace for LitePullConsumer may not work correctly

Posted by GitBox <gi...@apache.org>.
cserwen commented on issue #4606:
URL: https://github.com/apache/rocketmq/issues/4606#issuecomment-1184322105

   > Good catch,Could you submit a PR to solve this issue?
   
   @zhangjidi2016  Ok, I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] zhangjidi2016 commented on issue #4606: Trace for LitePullConsumer may not work correctly

Posted by GitBox <gi...@apache.org>.
zhangjidi2016 commented on issue #4606:
URL: https://github.com/apache/rocketmq/issues/4606#issuecomment-1184234338

   Good catch,Could you submit a PR to solve this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin closed issue #4606: Trace for LitePullConsumer may not work correctly

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #4606: Trace for LitePullConsumer may not work correctly
URL: https://github.com/apache/rocketmq/issues/4606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org