[GitHub] [maven] cstamas commented on a diff in pull request #712: Provide file transformer API replacement in Maven

[GitBox <gi...@apache.org>]

cstamas commented on code in PR #712:
URL: https://github.com/apache/maven/pull/712#discussion_r846613885


##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -261,9 +261,37 @@ else if ( request.isUpdateSnapshots() )
         mavenRepositorySystem.injectProxy( session, request.getPluginArtifactRepositories() );
         mavenRepositorySystem.injectAuthentication( session, request.getPluginArtifactRepositories() );
 
-        if ( Features.buildConsumer( request.getUserProperties() ).isActive() )
+        if ( !installRequestTransformers.isEmpty() )
+        {
+            if ( logger.isDebugEnabled() )
+            {
+                logger.debug( "Applying install request transformers (shown in order):" );
+                for ( InstallRequestTransformer transformer : installRequestTransformers )
+                {
+                    logger.debug( " * {}", transformer.getClass() );
+                }
+                logger.debug( "" );
+            }
+            session.getData().set(
+                    InstallRequestTransformer.KEY,
+                    new ChainedInstallRequestTransformer( installRequestTransformers )
+            );
+        }
+        if ( !deployRequestTransformers.isEmpty() )
         {
-            session.setFileTransformerManager( a -> getTransformersForArtifact( a, session.getData() ) );

Review Comment:
   Do not use FileTransformer API anymore, in short. If this get's accepted, you will want to implement DeployRequestTransformer component... but let's go baby steps first, and make sure this would work for you too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org