You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by ajs6f <gi...@git.apache.org> on 2017/11/04 15:47:44 UTC
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/304
JENA-1418: Upgrading minor dependencies and plugins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1418
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit 548770743dff4dae6a26ae40c8d1abaf613a9daf
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T14:49:41Z
Upgrading commons-io and commons-codec
commit 75d17cdbb2b788e5fc270226863cb0dd0a911c83
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T14:53:20Z
Upgrading commons-csv
commit 589fe44ada8a78985af5389efc2593017b51eb61
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T15:00:18Z
Upgrading Log4j2
commit dd5996150add112587d4a31fd56dd062be21f160
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T15:05:17Z
Upgrading contract test dependencies
commit 9f93514b78099076257836e754a63253ab71a3e0
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T15:22:30Z
Maven plugin updates
commit 6c100d92be885f13c31c2674ead85ba2a7f2b383
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T15:29:53Z
Moving Shiro dependency management
commit 56f2f6bd7641a408a9821d690d0f961f03ff796d
Author: ajs6f <aj...@apache.org>
Date: 2017-11-04T15:47:09Z
Upgrading Shiro
----
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148943114
--- Diff: jena-project/pom.xml ---
@@ -74,13 +75,14 @@
-->
<ver.httpcore-osgi>${ver.httpcore}</ver.httpcore-osgi>
<ver.httpclient-osgi>${ver.httpclient}</ver.httpclient-osgi>
+
+ <ver.shiro>1.4.0</ver.shiro>
- <ver.commons-codec>1.10</ver.commons-codec>
<ver.lucene>6.4.1</ver.lucene>
<ver.elasticsearch>5.2.2</ver.elasticsearch>
<!-- elasticsearch uses this by reflection -->
- <ver.log4j2>2.7</ver.log4j2>
+ <ver.log4j2>2.9.1</ver.log4j2>
--- End diff --
Given the warning in the comment, sticking to 2.7 is safer (it is what ES depends on).
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148941264
--- Diff: jena-fuseki2/jena-fuseki-war/pom.xml ---
@@ -68,9 +68,7 @@
<plugins>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
--- End diff --
For uniformity, I'd rather we left the `<groupId>org.apache.maven.plugins</groupId>` in.
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148943186
--- Diff: jena-permissions/pom.xml ---
@@ -19,9 +19,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
- <groupId>org.apache.jena</groupId>
<artifactId>jena-permissions</artifactId>
- <version>3.6.0-SNAPSHOT</version>
--- End diff --
This isn't "Upgrading minor dependencies".
IIRC Having the version in the module is, (or was - maven changes) necessary so that modules can be built on their own during development.
This is the style elsewhere in the project - one change and not others seems odd.
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148943098
--- Diff: jena-project/pom.xml ---
@@ -813,7 +833,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-report-plugin</artifactId>
- <version>2.18.1</version>
+ <version>2.20.1</version>
<configuration>
--- End diff --
From the parent? We may have had to set this to override in the past but that has moved on.
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148943111
--- Diff: jena-project/pom.xml ---
@@ -668,8 +682,8 @@
</plugin>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
+ <version>3.0.1</version>
--- End diff --
Isn't this inherited from the apache parent POM? Ditto others.
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148941258
--- Diff: jena-fuseki2/pom.xml ---
@@ -61,8 +61,7 @@
</licenses>
<properties>
- <ver.jetty>9.4.5.v20170502</ver.jetty>
- <ver.shiro>1.2.4</ver.shiro>
+ <ver.jetty>9.4.7.v20170914</ver.jetty>
--- End diff --
If you want to be consistent, this should be in jena-project.
The general idea was that this POM contained the Fuseki specific items, hence versions limited in use to Fuseki were put here. Not sure how much this style is used elsewhere in Jena.
An alternative is that we have no intermediate POM and put every in the project's parent.
jena-project was done that way at short notice so may we make the top POM also the parent.
All-in-all, how about making this PR about versions and having a wider discussion about build design?
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/304#discussion_r148943100
--- Diff: jena-project/pom.xml ---
@@ -740,18 +754,17 @@
</plugin>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
+ <version>3.0.2</version>
<configuration>
<overWriteReleases>false</overWriteReleases>
<overWriteIfNewer>true</overWriteIfNewer>
</configuration>
</plugin>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
- <version>2.9</version>
--- End diff --
Can we remove this plugin all together? Now Eclipse has built-in maven support, I don't think this plugin is necessary. Need to check more widely first.
---
[GitHub] jena pull request #304: JENA-1418: Upgrading minor dependencies and plugins
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/304
---