You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/01 13:38:28 UTC

[GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #415: Network Monitor: Runtime selection of DHCP/Static IP with fall back set by fsutil/ipcfg and a polled mode for HW lacking a PHY interrupt

davids5 commented on a change in pull request #415:
URL: https://github.com/apache/incubator-nuttx-apps/pull/415#discussion_r498250902



##########
File path: netutils/netinit/Kconfig
##########
@@ -103,6 +103,18 @@ config NETINIT_LOSS_POLL_RATE
 		The network monitor will check the PHY link state every
 		NETINIT_LOSS_POLL_RATE seconds for link loss.
 
+config NETINIT_FALLBACK
+	int "The number of failed DHCP attempts to fall back to using static settings"
+	default 5
+	depends on !ARCH_PHY_INTERRUPT && ARCH_PHY_POLLED && BOARDCTL_NETCONF

Review comment:
       @xiaoxiang781216 - Thank you I missed the one. I think it need to be FSUTIL_IPCFG to work. This is what provides the static IP. 
   
   As far as ARCH_PHY_POLLED.  I do not have HW with the IRQ connected. The timing on the fall back is condition by the ARCH_PHY_POLLED, so I am not sure how it will work.
   
   Do you have HW with the IRQ connected? Can you test it? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org