[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2934: hide assistedQueryColumn when desc EncryptTable

[GitBox <gi...@apache.org>]

tristaZero commented on issue #2934: hide assistedQueryColumn when  desc EncryptTable
URL: https://github.com/apache/incubator-shardingsphere/pull/2934#issuecomment-527129799
 
 
   Hi, @betterjava I am sorry for not giving your reply quickly, after reviewing your pr, it is great, i think. But this issue need to be updated, i think it is also easy for u, so can u try to modify this pr to make this feature better?
   **The updated issue is:**
   > Instead of hiding the AssistedQueryColumns, we should show the logicColumns to users. i.e, You need to hide all the AssistedQueryColumns and cipherColumns, and show encryptColumns to user.
   One encryptDataSource may contain mulitple encryptTables, and one encryptTable may contain multiple encryptColumns, and one encryptColumn may contain AssistedQueryColumn and cipherColumn. You can read EncryptTable.java to learn the relationship of them.
   Therefore, we want user see the names of encryptColumn, not AssistedQueryColumn or cipherColumn.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services