You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2011/06/13 23:12:28 UTC

svn commit: r1135285 [2/2] - in /myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler: ./ src/main/java/org/apache/myfaces/commons/resourcehandler/ src/main/java/org/apache/myfaces/commons/resourcehandler/application/ src/main/java/org/apach...

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ClassLoaderResourceLoader.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ClassLoaderResourceLoader.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ClassLoaderResourceLoader.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ClassLoaderResourceLoader.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,519 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import java.io.InputStream;
+import java.net.URL;
+
+import javax.faces.application.ProjectStage;
+import javax.faces.context.FacesContext;
+
+import org.apache.myfaces.commons.util.ClassUtils;
+
+/**
+ * A resource loader implementation which loads resources from the thread ClassLoader.
+ * 
+ */
+public class ClassLoaderResourceLoader extends ResourceLoader
+{
+    //public final static String JAVAX_FACES_LIBRARY_NAME = "javax.faces";
+    //public final static String JSF_JS_RESOURCE_NAME = "jsf.js";
+
+    //public final static String MYFACES_JS_RESOURCE_NAME = "oamSubmit.js";
+    //public final static String MYFACES_LIBRARY_NAME = "org.apache.myfaces";
+
+    
+    /**
+     * It checks version like this: 1, 1_0, 1_0_0, 100_100
+     * 
+     * Used on getLibraryVersion to filter resource directories
+     **/
+    //protected static Pattern VERSION_CHECKER = Pattern.compile("\\p{Digit}+(_\\p{Digit}*)*");
+
+    /**
+     * It checks version like this: /1.js, /1_0.js, /1_0_0.js, /100_100.js
+     * 
+     * Used on getResourceVersion to filter resources
+     **/
+    //protected static Pattern RESOURCE_VERSION_CHECKER = Pattern.compile("/\\p{Digit}+(_\\p{Digit}*)*\\..*");
+
+    /*
+    private FileFilter _libraryFileFilter = new FileFilter()
+    {
+        public boolean accept(File pathname)
+        {
+            if (pathname.isDirectory() && VERSION_CHECKER.matcher(pathname.getName()).matches())
+            {
+                return true;
+            }
+            return false;
+        }
+    };*/
+
+    /*
+    private FileFilter _resourceFileFilter = new FileFilter()
+    {
+        public boolean accept(File pathname)
+        {
+            if (pathname.isDirectory() && RESOURCE_VERSION_CHECKER.matcher(pathname.getName()).matches())
+            {
+                return true;
+            }
+            return false;
+        }
+    };*/
+    
+    private final boolean _developmentStage;
+
+    public ClassLoaderResourceLoader(String prefix)
+    {
+        super(prefix);
+        _developmentStage = FacesContext.getCurrentInstance().isProjectStage(ProjectStage.Development);
+    }
+
+    @Override
+    public String getLibraryVersion(String path)
+    {
+        return null;
+        /*
+        String libraryVersion = null;
+        if (getPrefix() != null)
+            path = getPrefix() + '/' + path;
+
+        URL url = getClassLoader().getResource(path);
+
+        if (url == null)
+        {
+            // This library does not exists for this
+            // ResourceLoader
+            return null;
+        }
+
+        // The problem here is how to scan the directory. When a ClassLoader
+        // is used two cases could occur
+        // 1. The files are unpacked so we can use Url.toURI and crawl
+        // the directory using the api for files.
+        // 2. The files are packed in a jar. This case is more tricky,
+        // because we only have a URL. Checking the jar api we can use
+        // JarURLConnection (Sounds strange, but the api of
+        // URL.openConnection says that for a jar connection a
+        // JarURLConnection is returned). From this point we can access
+        // to the jar api and solve the algoritm.
+        if (url.getProtocol().equals("file"))
+        {
+            try
+            {
+                File directory = new File(url.toURI());
+                if (directory.isDirectory())
+                {
+                    File[] versions = directory.listFiles(_libraryFileFilter);
+                    for (int i = 0; i < versions.length; i++)
+                    {
+                        String version = versions[i].getName();
+                        if (VERSION_CHECKER.matcher(version).matches())
+                        {
+                            if (libraryVersion == null)
+                            {
+                                libraryVersion = version;
+                            }
+                            else if (getVersionComparator().compare(libraryVersion, version) < 0)
+                            {
+                                libraryVersion = version;
+                            }
+                        }
+                    }
+                }
+            }
+            catch (URISyntaxException e)
+            {
+                // Just return null, because library version cannot be
+                // resolved.
+                Logger log = Logger.getLogger(ClassLoaderResourceLoader.class.getName()); 
+                if (log.isLoggable(Level.WARNING))
+                {
+                    log.log(Level.WARNING, "url "+url.toString()+" cannot be translated to uri: "+e.getMessage(), e);
+                }
+            }
+        }
+        else if (isJarResourceProtocol(url.getProtocol()))
+        {
+            try
+            {
+                url = getClassLoader().getResource(path + '/');
+
+                if (url != null)
+                {
+                    JarURLConnection conn = (JarURLConnection)url.openConnection();
+                    // See DIGESTER-29 for related problem
+                    conn.setUseCaches(false);
+
+                    try
+                    {
+                        if (conn.getJarEntry().isDirectory())
+                        {
+                            // Unfortunately, we have to scan all entry files
+                            // because there is no proper api to scan it as a
+                            // directory tree.
+                            JarFile file = conn.getJarFile();
+                            for (Enumeration<JarEntry> en = file.entries(); en.hasMoreElements();)
+                            {
+                                JarEntry entry = en.nextElement();
+                                String entryName = entry.getName();
+    
+                                if (entryName.startsWith(path + '/'))
+                                {
+                                    if (entryName.length() == path.length() + 1)
+                                    {
+                                        // the same string, just skip it
+                                        continue;
+                                    }
+    
+                                    if (entryName.charAt(entryName.length() - 1) != '/')
+                                    {
+                                        // Skip files
+                                        continue;
+                                    }
+    
+                                    entryName = entryName.substring(path.length() + 1, entryName.length() - 1);
+    
+                                    if (entryName.indexOf('/') >= 0)
+                                    {
+                                        // Inner Directory
+                                        continue;
+                                    }
+    
+                                    String version = entryName;
+                                    if (VERSION_CHECKER.matcher(version).matches())
+                                    {
+                                        if (libraryVersion == null)
+                                        {
+                                            libraryVersion = version;
+                                        }
+                                        else if (getVersionComparator().compare(libraryVersion, version) < 0)
+                                        {
+                                            libraryVersion = version;
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
+                    finally
+                    {
+                        //See TRINIDAD-73
+                        //just close the input stream again if
+                        //by inspecting the entries the stream
+                        //was let open.
+                        try
+                        {
+                            conn.getInputStream().close();
+                        }
+                        catch (Exception exception)
+                        {
+                            // Ignored
+                        }
+                    }
+                }
+            }
+            catch (IOException e)
+            {
+                // Just return null, because library version cannot be
+                // resolved.
+                Logger log = Logger.getLogger(ClassLoaderResourceLoader.class.getName()); 
+                if (log.isLoggable(Level.WARNING))
+                {
+                    log.log(Level.WARNING, "IOException when scanning for resource in jar file:", e);
+                }
+            }
+        }
+        return libraryVersion;
+        */
+    }
+
+    @Override
+    public InputStream getResourceInputStream(ResourceMeta resourceMeta)
+    {
+        InputStream is = null;
+        if (getPrefix() != null && !"".equals(getPrefix()))
+        {
+            String name = getPrefix() + '/' + resourceMeta.getResourceIdentifier();
+            is = getClassLoader().getResourceAsStream(name);
+            if (is == null)
+            {
+                is = this.getClass().getClassLoader().getResourceAsStream(name);
+            }
+            return is;
+        }
+        else
+        {
+            is = getClassLoader().getResourceAsStream(resourceMeta.getResourceIdentifier());
+            if (is == null)
+            {
+                is = this.getClass().getClassLoader().getResourceAsStream(resourceMeta.getResourceIdentifier());
+            }
+            return is;
+        }
+    }
+
+    @Override
+    public URL getResourceURL(ResourceMeta resourceMeta)
+    {
+        URL url = null;
+        if (getPrefix() != null && !"".equals(getPrefix()))
+        {
+            String name = getPrefix() + '/' + resourceMeta.getResourceIdentifier();
+            url = getClassLoader().getResource(name);
+            if (url == null)
+            {
+                url = this.getClass().getClassLoader().getResource(name);
+            }
+            return url;
+        }
+        else
+        {
+            url = getClassLoader().getResource(resourceMeta.getResourceIdentifier());
+            if (url == null)
+            {
+                url = this.getClass().getClassLoader().getResource(resourceMeta.getResourceIdentifier());
+            }
+            return url;
+        }
+    }
+
+    @Override
+    public String getResourceVersion(String path)
+    {
+        return null;
+        /*
+        String resourceVersion = null;
+
+        if (getPrefix() != null)
+            path = getPrefix() + '/' + path;
+
+        URL url = getClassLoader().getResource(path);
+
+        if (url == null)
+        {
+            // This library does not exists for this
+            // ResourceLoader
+            return null;
+        }
+
+        if (url.getProtocol().equals("file"))
+        {
+            try
+            {
+                File directory = new File(url.toURI());
+                if (directory.isDirectory())
+                {
+                    File[] versions = directory.listFiles(_resourceFileFilter);
+                    for (int i = 0; i < versions.length; i++)
+                    {
+                        String version = versions[i].getName();
+                        if (resourceVersion == null)
+                        {
+                            resourceVersion = version;
+                        }
+                        else if (getVersionComparator().compare(resourceVersion, version) < 0)
+                        {
+                            resourceVersion = version;
+                        }
+                    }
+                    //Since it is a directory and no version found set resourceVersion as invalid
+                    if (resourceVersion == null)
+                    {
+                        resourceVersion = VERSION_INVALID;
+                    }
+                }
+            }
+            catch (URISyntaxException e)
+            {
+                Logger log = Logger.getLogger(ClassLoaderResourceLoader.class.getName()); 
+                if (log.isLoggable(Level.WARNING))
+                {
+                    log.log(Level.WARNING, "url "+url.toString()+" cannot be translated to uri: "+e.getMessage(), e);
+                }
+            }
+        }
+        else if (isJarResourceProtocol(url.getProtocol()))
+        {
+            try
+            {
+                url = getClassLoader().getResource(path + '/');
+
+                if (url != null)
+                {
+                    JarURLConnection conn = (JarURLConnection)url.openConnection();
+                    // See DIGESTER-29 for related problem
+                    conn.setUseCaches(false);
+
+                    try
+                    {
+                        if (conn.getJarEntry().isDirectory())
+                        {
+                            // Unfortunately, we have to scan all entry files
+                            JarFile file = conn.getJarFile();
+                            for (Enumeration<JarEntry> en = file.entries(); en.hasMoreElements();)
+                            {
+                                JarEntry entry = en.nextElement();
+                                String entryName = entry.getName();
+    
+                                if (entryName.startsWith(path + '/'))
+                                {
+                                    if (entryName.length() == path.length() + 1)
+                                    {
+                                        // the same string, just skip it
+                                        continue;
+                                    }
+        
+                                    entryName = entryName.substring(path.length());
+                                    if (RESOURCE_VERSION_CHECKER.matcher(entryName).matches())
+                                    {
+                                        String version = entryName.substring(1, entryName.lastIndexOf('.'));
+                                        if (resourceVersion == null)
+                                        {
+                                            resourceVersion = version;
+                                        }
+                                        else if (getVersionComparator().compare(resourceVersion, version) < 0)
+                                        {
+                                            resourceVersion = version;
+                                        }
+                                    }
+                                }
+                            }
+                            if (resourceVersion == null)
+                            {
+                                resourceVersion = VERSION_INVALID;
+                            }
+                        }
+                    }
+                    finally
+                    {
+                        //See TRINIDAD-73
+                        //just close the input stream again if
+                        //by inspecting the entries the stream
+                        //was let open.
+                        try
+                        {
+                            conn.getInputStream().close();
+                        }
+                        catch (Exception exception)
+                        {
+                            // Ignored
+                        }
+                    }
+
+                }
+            }
+            catch (IOException e)
+            {
+                // Just return null, because library version cannot be
+                // resolved.
+                Logger log = Logger.getLogger(ClassLoaderResourceLoader.class.getName()); 
+                if (log.isLoggable(Level.WARNING))
+                {
+                    log.log(Level.WARNING, "IOException when scanning for resource in jar file:", e);
+                }
+            }
+        }
+        return resourceVersion;
+        */
+    }
+
+    @Override
+    public ResourceMeta createResourceMeta(String prefix, String libraryName, String libraryVersion,
+                                           String resourceName, String resourceVersion)
+    {
+        //if (_developmentStage && libraryName != null && 
+        //        JAVAX_FACES_LIBRARY_NAME.equals(libraryName) &&
+        //        JSF_JS_RESOURCE_NAME.equals(resourceName))
+        //{
+            // InternalClassLoaderResourceLoader will serve it, so return null in this case.
+        //    return null;
+        //} else if (_developmentStage && libraryName != null &&
+        //        MYFACES_LIBRARY_NAME.equals(libraryName) &&
+        //        MYFACES_JS_RESOURCE_NAME.equals(resourceName)) {
+            // InternalClassLoaderResourceLoader will serve it, so return null in this case.
+        //     return null;
+        //} else
+        //{
+            return new ResourceMetaImpl(prefix, libraryName, libraryVersion, resourceName, resourceVersion);
+        //}
+    }
+
+    /**
+     * Returns the ClassLoader to use when looking up resources under the top level package. By default, this is the
+     * context class loader.
+     * 
+     * @return the ClassLoader used to lookup resources
+     */
+    protected ClassLoader getClassLoader()
+    {
+        return ClassUtils.getContextClassLoader();
+    }
+
+    @Override
+    public boolean libraryExists(String libraryName)
+    {
+        if (getPrefix() != null && !"".equals(getPrefix()))
+        {
+            URL url = getClassLoader().getResource(getPrefix() + '/' + libraryName);
+            if (url == null)
+            {
+                url = this.getClass().getClassLoader().getResource(getPrefix() + '/' + libraryName);
+            }
+            if (url != null)
+            {
+                return true;
+            }
+        }
+        else
+        {
+            URL url = getClassLoader().getResource(libraryName);
+            if (url == null)
+            {
+                url = this.getClass().getClassLoader().getResource(libraryName);
+            }
+            if (url != null)
+            {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    /**
+     * <p>Determines whether the given URL resource protocol refers to a JAR file. Note that
+     * BEA WebLogic and IBM WebSphere don't use the "jar://" protocol for some reason even
+     * though you can treat these resources just like normal JAR files, i.e. you can ignore
+     * the difference between these protocols after this method has returned.</p>
+     *
+     * @param protocol the URL resource protocol you want to check
+     *
+     * @return <code>true</code> if the given URL resource protocol refers to a JAR file,
+     *          <code>false</code> otherwise
+     */
+    /*
+    private static boolean isJarResourceProtocol(String protocol)
+    {
+        // Websphere uses the protocol "wsjar://" and Weblogic uses the protocol "zip://".
+        return "jar".equals(protocol) || "wsjar".equals(protocol) || "zip".equals(protocol); 
+    }*/
+
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ExternalContextResourceLoader.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ExternalContextResourceLoader.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ExternalContextResourceLoader.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ExternalContextResourceLoader.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import java.io.InputStream;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.util.Iterator;
+import java.util.Set;
+import java.util.regex.Pattern;
+
+import javax.faces.context.FacesContext;
+
+/**
+ * A resource loader implementation which loads resources from the webapp root. It uses the methods on ExternalContext
+ * for handle resources.
+ * 
+ */
+public class ExternalContextResourceLoader extends ResourceLoader
+{
+    /**
+     * It checks version like this: /1/, /1_0/, /1_0_0/, /100_100/
+     * 
+     * Used on getLibraryVersion to filter resource directories
+     **/
+    protected static Pattern VERSION_CHECKER = Pattern.compile("/\\p{Digit}+(_\\p{Digit}*)*/");
+
+    /**
+     * It checks version like this: /1.js, /1_0.js, /1_0_0.js, /100_100.js
+     * 
+     * Used on getResourceVersion to filter resources
+     **/
+    protected static Pattern RESOURCE_VERSION_CHECKER = Pattern.compile("/\\p{Digit}+(_\\p{Digit}*)*\\..*");
+
+    public ExternalContextResourceLoader(String prefix)
+    {
+        super(prefix);
+    }
+
+    protected Set<String> getResourcePaths(String path)
+    {
+        return FacesContext.getCurrentInstance().getExternalContext().getResourcePaths(getPrefix() + '/' + path);
+    }
+
+    @Override
+    public String getResourceVersion(String path)
+    {
+        String resourceVersion = null;
+        Set<String> resourcePaths = this.getResourcePaths(path);
+        if (getPrefix() != null)
+            path = getPrefix() + '/' + path;
+
+        if (null != resourcePaths && !resourcePaths.isEmpty())
+        {
+            // resourceVersion = // execute the comment
+            // Look in the resourcePaths for versioned resources.
+            // If one or more versioned resources are found, take
+            // the one with the "highest" version number as the value
+            // of resourceVersion. If no versioned libraries
+            // are found, let resourceVersion remain null.
+            for (String resourcePath : resourcePaths)
+            {
+                String version = resourcePath.substring(path.length());
+
+                if (RESOURCE_VERSION_CHECKER.matcher(version).matches())
+                {
+                    version = version.substring(1, version.lastIndexOf('.'));
+                    if (resourceVersion == null)
+                    {
+                        resourceVersion = version;
+                    }
+                    else if (getVersionComparator().compare(resourceVersion, version) < 0)
+                    {
+                        resourceVersion = version;
+                    }
+                }
+            }
+            //Since it is a directory and no version was found, set as invalid
+            if (resourceVersion == null)
+            {
+                resourceVersion = VERSION_INVALID;
+            }
+        }
+        return resourceVersion;
+    }
+
+    @Override
+    public String getLibraryVersion(String path)
+    {
+        String libraryVersion = null;
+        Set<String> libraryPaths = this.getResourcePaths(path);
+        path = getPrefix() + '/' + path;
+        if (null != libraryPaths && !libraryPaths.isEmpty())
+        {
+            // Look in the libraryPaths for versioned libraries.
+            // If one or more versioned libraries are found, take
+            // the one with the "highest" version number as the value
+            // of libraryVersion. If no versioned libraries
+            // are found, let libraryVersion remain null.
+
+            for (Iterator<String> it = libraryPaths.iterator(); it.hasNext();)
+            {
+                String libraryPath = it.next();
+                String version = libraryPath.substring(path.length());
+
+                if (VERSION_CHECKER.matcher(version).matches())
+                {
+                    version = version.substring(1, version.length() - 1);
+                    if (libraryVersion == null)
+                    {
+                        libraryVersion = version;
+                    }
+                    else if (getVersionComparator().compare(libraryVersion, version) < 0)
+                    {
+                        libraryVersion = version;
+                    }
+                }
+            }
+        }
+        return libraryVersion;
+    }
+
+    @Override
+    public URL getResourceURL(ResourceMeta resourceMeta)
+    {
+        try
+        {
+            return FacesContext.getCurrentInstance().getExternalContext().getResource(
+                getPrefix() + '/' + resourceMeta.getResourceIdentifier());
+        }
+        catch (MalformedURLException e)
+        {
+            return null;
+        }
+    }
+
+    @Override
+    public InputStream getResourceInputStream(ResourceMeta resourceMeta)
+    {
+        return FacesContext.getCurrentInstance().getExternalContext().getResourceAsStream(
+            getPrefix() + '/' + resourceMeta.getResourceIdentifier());
+    }
+
+    @Override
+    public ResourceMeta createResourceMeta(String prefix, String libraryName, String libraryVersion,
+                                           String resourceName, String resourceVersion)
+    {
+        return new ResourceMetaImpl(prefix, libraryName, libraryVersion, resourceName, resourceVersion);
+    }
+
+    @Override
+    public boolean libraryExists(String libraryName)
+    {
+        if (getPrefix() != null && !"".equals(getPrefix()))
+        {
+            try
+            {
+                URL url =
+                    FacesContext.getCurrentInstance().getExternalContext().getResource(
+                        getPrefix() + '/' + libraryName);
+                if (url != null)
+                {
+                    return true;
+                }
+            }
+            catch (MalformedURLException e)
+            {
+                return false;
+            }
+        }
+        else
+        {
+            try
+            {
+
+                URL url = FacesContext.getCurrentInstance().getExternalContext().getResource(libraryName);
+
+                if (url != null)
+                {
+                    return true;
+                }
+            }
+            catch (MalformedURLException e)
+            {
+                return false;
+            }
+        }
+        return false;
+    }
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerCache.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerCache.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerCache.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerCache.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+import javax.faces.application.ProjectStage;
+import javax.faces.context.ExternalContext;
+import javax.faces.context.FacesContext;
+
+import org.apache.myfaces.buildtools.maven2.plugin.builder.annotation.JSFWebConfigParam;
+import org.apache.myfaces.commons.util.WebConfigParamUtils;
+
+public class ResourceHandlerCache
+{
+    private static final Logger log = Logger
+            .getLogger(ResourceHandlerCache.class.getName());
+
+    private Boolean _resourceCacheEnabled = null;
+    private Map<ResourceKey, ResourceValue> _resourceCacheMap = null;
+
+    @JSFWebConfigParam(defaultValue = "500", since = "2.0.2")
+    private static final String RESOURCE_HANDLER_CACHE_SIZE_ATTRIBUTE = "org.apache.myfaces.RESOURCE_HANDLER_CACHE_SIZE";
+    private static final int RESOURCE_HANDLER_CACHE_DEFAULT_SIZE = 500;
+
+    @JSFWebConfigParam(defaultValue = "true", since = "2.0.2")
+    private static final String RESOURCE_HANDLER_CACHE_ENABLED_ATTRIBUTE = "org.apache.myfaces.RESOURCE_HANDLER_CACHE_ENABLED";
+    private static final boolean RESOURCE_HANDLER_CACHE_ENABLED_DEFAULT = true;
+
+    public ResourceValue getResource(String resourceName, String libraryName,
+            String contentType, String localePrefix)
+    {
+        if (!isResourceCachingEnabled() || _resourceCacheMap == null)
+            return null;
+
+        if (log.isLoggable(Level.FINE))
+            log.log(Level.FINE, "Attemping to get resource from cache for "
+                    + resourceName);
+
+        ResourceKey key = new ResourceKey(resourceName, libraryName, contentType, localePrefix);
+
+        return _resourceCacheMap.get(key);
+    }
+    
+    public boolean containsResource(String resourceName, String libraryName, String contentType, String localePrefix)
+    {
+        if (!isResourceCachingEnabled() || _resourceCacheMap == null)
+            return false;
+
+        ResourceKey key = new ResourceKey(resourceName, libraryName, contentType, localePrefix);
+        return _resourceCacheMap.containsKey(key);
+    }
+
+    public void putResource(String resourceName, String libraryName,
+            String contentType, String localePrefix, ResourceMeta resource, ResourceLoader loader)
+    {
+        if (!isResourceCachingEnabled())
+            return;
+
+        if (log.isLoggable(Level.FINE))
+            log.log(Level.FINE, "Attemping to put resource to cache for "
+                    + resourceName);
+
+        if (_resourceCacheMap == null)
+        {
+            if (log.isLoggable(Level.FINE))
+                log.log(Level.FINE, "Initializing resource cache map");
+            _resourceCacheMap = Collections
+                    .synchronizedMap(new _ResourceMap<ResourceKey, ResourceValue>(
+                            getMaxSize()));
+        }
+
+        _resourceCacheMap.put(new ResourceKey(resourceName, libraryName,
+                contentType, localePrefix), new ResourceValue(resource, loader));
+    }
+
+    private boolean isResourceCachingEnabled()
+    {
+        if (_resourceCacheEnabled == null)
+        {
+            FacesContext facesContext = FacesContext.getCurrentInstance();
+
+            //first, check to make sure that ProjectStage is production, if not, skip caching
+            if (!facesContext.isProjectStage(ProjectStage.Production))
+            {
+                return _resourceCacheEnabled = Boolean.FALSE;
+            }
+
+            ExternalContext externalContext = facesContext.getExternalContext();
+            if (externalContext == null)
+                return false; //don't cache right now, but don't disable it yet either
+
+            //if in production, make sure that the cache is not explicitly disabled via context param
+            _resourceCacheEnabled = WebConfigParamUtils.getBooleanInitParameter(externalContext, 
+                    ResourceHandlerCache.RESOURCE_HANDLER_CACHE_ENABLED_ATTRIBUTE,
+                    ResourceHandlerCache.RESOURCE_HANDLER_CACHE_ENABLED_DEFAULT);
+
+            if (log.isLoggable(Level.FINE))
+            {
+                log.log(Level.FINE, "MyFaces Resource Caching Enabled="
+                        + _resourceCacheEnabled);
+            }
+        }
+        return _resourceCacheEnabled;
+    }
+
+    private int getMaxSize()
+    {
+        
+        ExternalContext externalContext = FacesContext.getCurrentInstance()
+                .getExternalContext();
+        return WebConfigParamUtils.getIntegerInitParameter(externalContext, 
+                RESOURCE_HANDLER_CACHE_SIZE_ATTRIBUTE, RESOURCE_HANDLER_CACHE_DEFAULT_SIZE);
+    }
+
+    public static class ResourceKey
+    {
+        private String resourceName;
+        private String libraryName;
+        private String contentType;
+        private String localePrefix;
+
+        public ResourceKey(String resourceName, String libraryName,
+                String contentType, String localePrefix)
+        {
+            this.resourceName = resourceName;
+            this.libraryName = libraryName;
+            this.contentType = contentType;
+            this.localePrefix = localePrefix;
+        }
+
+        @Override
+        public boolean equals(Object o)
+        {
+            if (this == o)
+            {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass())
+            {
+                return false;
+            }
+
+            ResourceKey that = (ResourceKey) o;
+
+            if (contentType != null ? !contentType.equals(that.contentType) : that.contentType != null)
+            {
+                return false;
+            }
+            if (libraryName != null ? !libraryName.equals(that.libraryName) : that.libraryName != null)
+            {
+                return false;
+            }
+            if (localePrefix != null ? !localePrefix.equals(that.localePrefix) : that.localePrefix != null)
+            {
+                return false;
+            }
+            if (resourceName != null ? !resourceName.equals(that.resourceName) : that.resourceName != null)
+            {
+                return false;
+            }
+
+            return true;
+        }
+
+        @Override
+        public int hashCode()
+        {
+            int result = resourceName != null ? resourceName.hashCode() : 0;
+            result = 31 * result + (libraryName != null ? libraryName.hashCode() : 0);
+            result = 31 * result + (contentType != null ? contentType.hashCode() : 0);
+            result = 31 * result + (localePrefix != null ? localePrefix.hashCode() : 0);
+            return result;
+        }
+    }
+
+    public static class ResourceValue
+    {
+        private ResourceMeta resourceMeta;
+        
+        private ResourceLoader resourceLoader;
+
+        public ResourceValue(ResourceMeta resourceMeta,
+                ResourceLoader resourceLoader)
+        {
+            super();
+            this.resourceMeta = resourceMeta;
+            this.resourceLoader = resourceLoader;
+        }
+
+        public ResourceMeta getResourceMeta()
+        {
+            return resourceMeta;
+        }
+
+        public ResourceLoader getResourceLoader()
+        {
+            return resourceLoader;
+        }
+    }
+
+    private static class _ResourceMap<K, V> extends LinkedHashMap<K, V>
+    {
+        private static final long serialVersionUID = 1L;
+        private int maxCapacity;
+
+        public _ResourceMap(int cacheSize)
+        {
+            // create map at max capacity and 1.1 load factor to avoid rehashing
+            super(cacheSize + 1, 1.1f, true);
+            maxCapacity = cacheSize;
+        }
+
+        @Override
+        protected boolean removeEldestEntry(Map.Entry<K, V> eldest)
+        {
+            return size() > maxCapacity;
+        }
+    }
+}
\ No newline at end of file

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerSupport.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerSupport.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerSupport.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceHandlerSupport.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import javax.faces.context.FacesContext;
+
+/**
+ * A utility class to isolate a ResourceHandler implementation from its
+ * underlying implementation
+ * 
+ * @author Leonardo Uribe (latest modification by $Author: lu4242 $)
+ * @version $Revision: 891494 $ $Date: 2009-12-16 19:42:18 -0500 (Mié, 16 Dic 2009) $
+ */
+public abstract class ResourceHandlerSupport
+{
+
+    /**
+     * Calculate the resource base path.
+     * 
+     * It should extract a string like:
+     * 
+     * ResourceHandler.RESOURCE_IDENTIFIER + '/' + getResourceName()
+     * 
+     * For example:
+     * 
+     * /javax.faces.resource/image.jpg
+     * 
+     * This is used on ResourceHandler.handleResourceRequest()
+     * 
+     */
+    public abstract String calculateResourceBasePath(FacesContext facesContext);
+
+    /**
+     * Return an array of resource loaders used to find resources
+     * using the standard. The order of ResourceLoaders define
+     * its precedence. 
+     * 
+     * @return
+     */
+    public abstract ResourceLoader[] getResourceLoaders();
+    
+    /**
+     * Check if the mapping used is done using extensions (.xhtml, .jsf)
+     * or if it is not (/faces/*)
+     * @return
+     */
+    public abstract boolean isExtensionMapping();
+    
+    /**
+     * Get the mapping used as prefix(/faces) or sufix(.jsf)
+     * 
+     * @return
+     */
+    public abstract String getMapping();
+    
+    /**
+     * Return the time when the app started. This is useful to set the
+     * "Last-Modified" header in some specific cases.
+     * 
+     * @return
+     */
+    public abstract long getStartupTime();
+    
+    /**
+     * Return the time that should be set on "Expires" header in a resource.
+     * 
+     * @return
+     */
+    public abstract long getMaxTimeExpires();
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceImpl.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceImpl.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceImpl.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceImpl.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,391 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.PushbackInputStream;
+import java.net.URL;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+import javax.el.ELContext;
+import javax.el.ELException;
+import javax.el.ValueExpression;
+import javax.faces.application.ProjectStage;
+import javax.faces.application.Resource;
+import javax.faces.application.ResourceHandler;
+import javax.faces.context.FacesContext;
+import javax.faces.event.ExceptionQueuedEvent;
+import javax.faces.event.ExceptionQueuedEventContext;
+
+/**
+ * Default implementation for resources
+ * 
+ * @author Leonardo Uribe (latest modification by $Author: lu4242 $)
+ * @version $Revision: 957739 $ $Date: 2010-06-24 17:27:40 -0500 (Jue, 24 Jun 2010) $
+ */
+public class ResourceImpl extends Resource
+{
+    public final static String JAVAX_FACES_LIBRARY_NAME = "javax.faces";
+    public final static String JSF_JS_RESOURCE_NAME = "jsf.js";
+
+
+    private ResourceMeta _resourceMeta;
+    private ResourceLoader _resourceLoader;
+    private ResourceHandlerSupport _resourceHandlerSupport;
+    
+    public ResourceImpl(ResourceMeta resourceMeta, 
+            ResourceLoader resourceLoader, ResourceHandlerSupport support, String contentType)
+    {
+        _resourceMeta = resourceMeta;
+        _resourceLoader = resourceLoader;
+        _resourceHandlerSupport = support;
+        setLibraryName(resourceMeta.getLibraryName());
+        setResourceName(resourceMeta.getResourceName());
+        setContentType(contentType);
+    }
+    
+    public ResourceLoader getResourceLoader()
+    {
+        return _resourceLoader;
+    }    
+    
+    @Override
+    public InputStream getInputStream() throws IOException
+    {
+        if (couldResourceContainValueExpressions())
+        {
+            return new ValueExpressionFilterInputStream(
+                    getResourceLoader().getResourceInputStream(_resourceMeta)); 
+        }
+        else
+        {
+            return getResourceLoader().getResourceInputStream(_resourceMeta);            
+        }
+    }
+    
+    private boolean couldResourceContainValueExpressions()
+    {
+        if (_resourceMeta.couldResourceContainValueExpressions())
+        {
+            return true;
+        }
+        else
+        {
+            //By default only css resource contain value expressions
+            String contentType = getContentType();
+    
+            return ("text/css".equals(contentType));
+        }
+    }
+
+    private class ValueExpressionFilterInputStream extends InputStream
+    {
+        private PushbackInputStream delegate;
+        
+        public ValueExpressionFilterInputStream(InputStream in)
+        {
+            super();
+            delegate = new PushbackInputStream(in,255);
+        }
+
+        @Override
+        public int read() throws IOException
+        {
+            int c1 = delegate.read();
+            
+            if (c1 == -1) return -1;
+            
+            if ( ((char)c1) == '#')
+            {
+                int c2 = delegate.read();
+                if (c2 == -1) return -1;
+                if (((char)c2) == '{')
+                {
+                    //It is a value expression. We need
+                    //to look for a occurrence of } to 
+                    //extract the expression and evaluate it,
+                    //the result should be unread.
+                    List<Integer> expressionList = new ArrayList<Integer>();
+                    int c3 = delegate.read();
+                    while ( c3 != -1 && ((char)c3) != '}' )
+                    {
+                        expressionList.add(c3);
+                        c3 = delegate.read();
+                    }
+                    
+                    if (c3 == -1)
+                    {
+                        //get back the data, because we can't
+                        //extract any value expression
+                        for (int i = 0; i < expressionList.size(); i++)
+                        {
+                            delegate.unread(expressionList.get(i));
+                        }
+                        delegate.unread(c2);
+                        return c1;
+                    }
+                    else
+                    {
+                        //EL expression found. Evaluate it and pushback
+                        //the result into the stream
+                        FacesContext context = FacesContext.getCurrentInstance();
+                        ELContext elContext = context.getELContext();
+                        try
+                        {
+                            ValueExpression ve = context.getApplication().
+                                getExpressionFactory().createValueExpression(
+                                        elContext,
+                                        "#{"+convertToExpression(expressionList)+"}",
+                                        String.class);
+                            String value = (String) ve.getValue(elContext);
+                            
+                            for (int i = value.length()-1; i >= 0 ; i--)
+                            {
+                                delegate.unread((int) value.charAt(i));
+                            }
+                        }
+                        catch(ELException e)
+                        {
+                            ExceptionQueuedEventContext equecontext = new ExceptionQueuedEventContext (context, e, null);
+                            context.getApplication().publishEvent (context, ExceptionQueuedEvent.class, equecontext);
+                            
+                            Logger log = Logger.getLogger(ResourceImpl.class.getName());
+                            if (log.isLoggable(Level.SEVERE))
+                                log.severe("Cannot evaluate EL expression "+convertToExpression(expressionList)+ " in resource " + getLibraryName()+":"+getResourceName());
+                            
+                            delegate.unread(c3);
+                            for (int i = expressionList.size()-1; i >= 0; i--)
+                            {
+                                delegate.unread(expressionList.get(i));
+                            }
+                            delegate.unread(c2);
+                            return c1;
+                        }
+                        
+                        //read again
+                        return delegate.read();
+                    }
+                }
+                else
+                {
+                    delegate.unread(c2);
+                    return c1;
+                }
+            }
+            else
+            {
+                //just continue
+                return c1;
+            }
+        }
+        
+        private String convertToExpression(List<Integer> expressionList)
+        {
+            char[] exprArray = new char[expressionList.size()];
+            
+            for (int i = 0; i < expressionList.size(); i++)
+            {
+                exprArray[i] = (char) expressionList.get(i).intValue();
+            }
+            return String.valueOf(exprArray);
+        }
+    }
+
+    @Override
+    public String getRequestPath()
+    {
+        String path;
+        if (_resourceHandlerSupport.isExtensionMapping())
+        {
+            path = ResourceHandler.RESOURCE_IDENTIFIER + '/' + 
+                getResourceName() + _resourceHandlerSupport.getMapping();
+        }
+        else
+        {
+            String mapping = _resourceHandlerSupport.getMapping(); 
+            path = ResourceHandler.RESOURCE_IDENTIFIER + '/' + getResourceName();
+            path = (mapping == null) ? path : mapping + path;
+        }
+ 
+        FacesContext facesContext = FacesContext.getCurrentInstance();
+        String metadata = null;
+        boolean useAmp = false;
+        if (getLibraryName() != null)
+        {
+            metadata = "?ln=" + getLibraryName();
+            path = path + metadata;
+            useAmp = true;
+            
+            if (!facesContext.isProjectStage(ProjectStage.Production)
+                    && JSF_JS_RESOURCE_NAME.equals(getResourceName()) 
+                    && JAVAX_FACES_LIBRARY_NAME.equals(getLibraryName()))
+            {
+                // append &stage=?? for all ProjectStages except Production
+                path = path + "&stage=" + facesContext.getApplication().getProjectStage().toString();
+            }
+        }
+        
+        return facesContext.getApplication().getViewHandler().getResourceURL(facesContext, path);
+    }
+
+    @Override
+    public Map<String, String> getResponseHeaders()
+    {
+        FacesContext facesContext = FacesContext.getCurrentInstance();
+        
+        if (facesContext.getApplication().getResourceHandler().isResourceRequest(facesContext))
+        {
+            Map<String, String> headers = new HashMap<String, String>();
+            
+            long lastModified;
+            try
+            {
+                lastModified = ResourceLoaderUtils.getResourceLastModified(this.getURL());
+            }
+            catch (IOException e)
+            {
+                lastModified = -1;
+            }
+            
+            // Here we have two cases: If the file could contain EL Expressions
+            // the last modified time is the greatest value between application startup and
+            // the value from file.
+            if (this.couldResourceContainValueExpressions() &&
+                    lastModified < _resourceHandlerSupport.getStartupTime())
+            {
+                lastModified = _resourceHandlerSupport.getStartupTime();
+            }            
+            else if (_resourceMeta instanceof AliasResourceMetaImpl &&
+                lastModified < _resourceHandlerSupport.getStartupTime())
+            {
+                // If the resource meta is aliased, the last modified time is the greatest 
+                // value between application startup and the value from file.
+                lastModified = _resourceHandlerSupport.getStartupTime();
+            }
+
+            if (lastModified >= 0)
+            {
+                headers.put("Last-Modified", ResourceLoaderUtils.formatDateHeader(lastModified));
+                
+                long expires;
+                if (facesContext.isProjectStage(ProjectStage.Development))
+                {
+                    // Force to expire now to prevent caching on development time.
+                    expires = System.currentTimeMillis();
+                }
+                else
+                {
+                    expires = System.currentTimeMillis() + _resourceHandlerSupport.getMaxTimeExpires();
+                }
+                headers.put("Expires", ResourceLoaderUtils.formatDateHeader(expires));
+            }
+            
+            return headers;
+        }
+        else
+        {
+            //No need to return headers 
+            return Collections.emptyMap();
+        }
+    }
+
+    @Override
+    public URL getURL()
+    {
+        return getResourceLoader().getResourceURL(_resourceMeta);
+    }
+
+    @Override
+    public boolean userAgentNeedsUpdate(FacesContext context)
+    {
+        // RFC2616 says related to If-Modified-Since header the following:
+        //
+        // "... The If-Modified-Since request-header field is used with a method to 
+        // make it conditional: if the requested variant has not been modified since 
+        // the time specified in this field, an entity will not be returned from 
+        // the server; instead, a 304 (not modified) response will be returned 
+        // without any message-body..."
+        // 
+        // This method is called from ResourceHandlerImpl.handleResourceRequest and if
+        // returns false send a 304 Not Modified response.
+        
+        String ifModifiedSinceString = context.getExternalContext().getRequestHeaderMap().get("If-Modified-Since");
+        
+        if (ifModifiedSinceString == null)
+        {
+            return true;
+        }
+        
+        Long ifModifiedSince = ResourceLoaderUtils.parseDateHeader(ifModifiedSinceString);
+        
+        if (ifModifiedSince == null)
+        {
+            return true;
+        }
+        
+        Long lastModified;
+        try
+        {
+            lastModified = ResourceLoaderUtils.getResourceLastModified(this.getURL());
+        }
+        catch (IOException exception)
+        {
+            lastModified = -1L;
+        }
+        
+        if (lastModified >= 0)
+        {
+            if (this.couldResourceContainValueExpressions() &&
+                    lastModified < _resourceHandlerSupport.getStartupTime())
+            {
+                lastModified = _resourceHandlerSupport.getStartupTime();
+            }
+            
+            // If the lastModified date is lower or equal than ifModifiedSince,
+            // the agent does not need to update.
+            // Note the lastModified time is set at milisecond precision, but when 
+            // the date is parsed and sent on ifModifiedSince, the exceding miliseconds
+            // are trimmed. So, we have to compare trimming this from the calculated
+            // lastModified time.
+            if ( (lastModified-(lastModified % 1000)) <= ifModifiedSince)
+            {
+                return false;
+            }
+        }
+        
+        return true;
+    }
+    
+    protected ResourceHandlerSupport getResourceHandlerSupport()
+    {
+        return _resourceHandlerSupport;
+    }
+    
+    protected ResourceMeta getResourceMeta()
+    {
+        return _resourceMeta;
+    }
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoader.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoader.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoader.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoader.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import java.io.InputStream;
+import java.net.URL;
+import java.util.Comparator;
+
+/**
+ * Base class for resource loaders.  Resource loaders can lookup resources 
+ * as URLs from arbitrary locations, including JAR files.
+ * 
+ * @author Leonardo Uribe (latest modification by $Author: lu4242 $)
+ * @version $Revision: 882702 $ $Date: 2009-11-20 15:16:07 -0500 (Vie, 20 Nov 2009) $
+ */
+public abstract class ResourceLoader
+{
+    
+    public static final String VERSION_INVALID = "INVALID";
+    
+    private String _prefix;
+    
+    public ResourceLoader(String prefix)
+    {
+        _prefix = prefix;
+    }
+
+    public abstract String getResourceVersion(String path);
+
+    /**
+     * Return the max available version found (if exists) or
+     * return null if no version available. 
+     */
+    public abstract String getLibraryVersion(String path);
+
+    /**
+     * Return the max available version found (if exists) or
+     * return null if no version available. 
+     */
+    public abstract URL getResourceURL(ResourceMeta resourceMeta);
+
+    public abstract InputStream getResourceInputStream(ResourceMeta resourceMeta);
+    
+    public abstract ResourceMeta createResourceMeta(String prefix, String libraryName, String libraryVersion,
+            String resourceName, String resourceVersion);
+    
+    public abstract boolean libraryExists(String libraryName);
+    
+    private Comparator<String> _versionComparator = null;
+
+    protected Comparator<String> getVersionComparator()
+    {
+        if (_versionComparator == null)
+        {
+            _versionComparator = new VersionComparator();
+        }
+        return _versionComparator;
+    }
+
+    protected void setVersionComparator(Comparator<String> versionComparator)
+    {
+        _versionComparator = versionComparator;
+    }
+
+    public class VersionComparator implements Comparator<String>
+    {
+
+        public int compare(String s1, String s2)
+        {
+            int n1 = 0;
+            int n2 = 0;
+            String o1 = s1;
+            String o2 = s2;
+
+            boolean p1 = true;
+            boolean p2 = true;
+
+            while (n1 == n2 && (p1 || p2))
+            {
+                int i1 = o1.indexOf('_');
+                int i2 = o2.indexOf('_');
+                if (i1 < 0)
+                {
+                    if (o1.length() > 0)
+                    {
+                        p1 = false;
+                        n1 = Integer.valueOf(o1);
+                        o1 = "";
+                    }
+                    else
+                    {
+                        p1 = false;
+                        n1 = 0;
+                    }
+                }
+                else
+                {
+                    n1 = Integer.valueOf(o1.substring(0, i1));
+                    o1 = o1.substring(i1 + 1);
+                }
+                if (i2 < 0)
+                {
+                    if (o2.length() > 0)
+                    {
+                        p2 = false;
+                        n2 = Integer.valueOf(o2);
+                        o2 = "";
+                    }
+                    else
+                    {
+                        p2 = false;
+                        n2 = 0;
+                    }
+                }
+                else
+                {
+                    n2 = Integer.valueOf(o2.substring(0, i2));
+                    o2 = o2.substring(i2 + 1);
+                }
+            }
+
+            if (n1 == n2)
+            {
+                return s1.length() - s2.length();
+            }
+            return n1 - n2;
+        }
+    }
+    
+    public String getPrefix()
+    {
+        return _prefix;
+    }
+
+    public void setPrefix(String prefix)
+    {
+        _prefix = prefix;
+    }
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoaderUtils.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoaderUtils.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoaderUtils.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceLoaderUtils.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.JarURLConnection;
+import java.net.URL;
+import java.net.URLConnection;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.Date;
+import java.util.Locale;
+import java.util.TimeZone;
+
+public class ResourceLoaderUtils
+{
+    // TODO: In tomcat and jetty it is implemented a Flyweight pattern when converting
+    // date headers. For now it is better keep this stuff simple.
+    private static final String HTTP_RESPONSE_DATE_HEADER =
+        "EEE, dd MMM yyyy HH:mm:ss zzz";
+    
+    private static final String[] HTTP_REQUEST_DATE_HEADER = {
+            "EEE, dd MMM yyyy HH:mm:ss zzz", "EEEEEE, dd-MMM-yy HH:mm:ss zzz",
+            "EEE MMMM d HH:mm:ss yyyy" };
+    
+    private static TimeZone __GMT = TimeZone.getTimeZone("GMT");
+
+    public static String formatDateHeader(long value)
+    {
+        SimpleDateFormat format = new SimpleDateFormat(
+                HTTP_RESPONSE_DATE_HEADER,
+                Locale.US);
+        format.setTimeZone(__GMT);
+        return format.format(new Date(value));
+    }
+    
+    public static Long parseDateHeader(String value)
+    {
+        Date date = null;
+        for (int i = 0; (date == null) && (i < HTTP_REQUEST_DATE_HEADER.length); i++)
+        {
+            try
+            {
+                SimpleDateFormat format = new SimpleDateFormat(
+                        HTTP_REQUEST_DATE_HEADER[i], Locale.US);
+                format.setTimeZone(__GMT);
+                date = format.parse(value);
+            }
+            catch (ParseException e)
+            {
+                ;
+            }
+        }
+        if (date == null)
+        {
+            return null;
+        }
+        return new Long(date.getTime());
+    }
+    
+    //Taken from trinidad URLUtils
+    public static long getResourceLastModified(URL url) throws IOException
+    {
+        if ("file".equals(url.getProtocol()))
+        {
+            String externalForm = url.toExternalForm();
+            // Remove the "file:"
+            File file = new File(externalForm.substring(5));
+
+            return file.lastModified();
+        }
+        else
+        {
+            return getResourceLastModified(url.openConnection());
+        }
+    }
+
+    //Taken from trinidad URLUtils
+    public static long getResourceLastModified(URLConnection connection) throws IOException
+    {
+        long modified;
+        if (connection instanceof JarURLConnection)
+        {
+            // The following hack is required to work-around a JDK bug.
+            // getLastModified() on a JAR entry URL delegates to the actual JAR file
+            // rather than the JAR entry.
+            // This opens internally, and does not close, an input stream to the JAR
+            // file.
+            // In turn, you cannot close it by yourself, because it's internal.
+            // The work-around is to get the modification date of the JAR file
+            // manually,
+            // and then close that connection again.
+
+            URL jarFileUrl = ((JarURLConnection) connection).getJarFileURL();
+            URLConnection jarFileConnection = jarFileUrl.openConnection();
+
+            try
+            {
+                modified = jarFileConnection.getLastModified();
+            }
+            finally
+            {
+                try
+                {
+                    jarFileConnection.getInputStream().close();
+                }
+                catch (Exception exception)
+                {
+                    // Ignored
+                }
+            }
+        }
+        else
+        {
+            modified = connection.getLastModified();
+        }
+
+        return modified;
+    }
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMeta.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMeta.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMeta.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMeta.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+/**
+ * Contains the metadata information to reference a resource 
+ * 
+ * @author Leonardo Uribe (latest modification by $Author: lu4242 $)
+ * @version $Revision: 946779 $ $Date: 2010-05-20 15:31:42 -0500 (Jue, 20 May 2010) $
+ */
+public abstract class ResourceMeta
+{
+    
+    public abstract String getLibraryName();
+    
+    public abstract String getResourceName();
+
+    public abstract String getLocalePrefix();
+
+    public abstract String getLibraryVersion();
+
+    public abstract String getResourceVersion();
+    
+    public abstract String getResourceIdentifier();
+    
+    public abstract boolean couldResourceContainValueExpressions();
+}

Added: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMetaImpl.java
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMetaImpl.java?rev=1135285&view=auto
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMetaImpl.java (added)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/java/org/apache/myfaces/commons/resourcehandler/resource/ResourceMetaImpl.java Mon Jun 13 21:12:27 2011
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.myfaces.commons.resourcehandler.resource;
+
+/**
+ * Contains the metadata information to reference a resource 
+ * 
+ * @author Leonardo Uribe (latest modification by $Author: lu4242 $)
+ * @version $Revision: 700544 $ $Date: 2008-09-30 13:44:02 -0500 (Mar, 30 Sep 2008) $
+ */
+public class ResourceMetaImpl extends ResourceMeta
+{
+
+    private final String _prefix;
+    private final String _libraryName;
+    private final String _libraryVersion;
+    private final String _resourceName;
+    private final String _resourceVersion;
+    
+    public ResourceMetaImpl(String prefix, String libraryName, String libraryVersion,
+            String resourceName, String resourceVersion)
+    {
+        _prefix = prefix;
+        _libraryName = libraryName;
+        _libraryVersion = libraryVersion;
+        _resourceName = resourceName;
+        _resourceVersion = resourceVersion;
+    }
+
+    public String getLibraryName()
+    {
+        return _libraryName;
+    }    
+    
+    public String getResourceName()
+    {
+        return _resourceName;
+    }    
+
+    public String getLocalePrefix()
+    {
+        return _prefix;
+    }
+
+    public String getLibraryVersion()
+    {
+        return _libraryVersion;
+    }
+
+    public String getResourceVersion()
+    {
+        return _resourceVersion;
+    }
+    
+    @Override
+    public String getResourceIdentifier()
+    {
+        StringBuilder builder = new StringBuilder();
+        boolean firstSlashAdded = false;
+        if (_prefix != null && _prefix.length() > 0)
+        {
+            builder.append(_prefix);
+            firstSlashAdded = true;
+        }
+        if (_libraryName != null)
+        {
+            if (firstSlashAdded) builder.append('/');
+            builder.append(_libraryName);
+            firstSlashAdded = true;
+        }
+        if (_libraryVersion != null)
+        {
+            if (firstSlashAdded) builder.append('/');
+            builder.append(_libraryVersion);
+            firstSlashAdded = true;
+        }
+        if (_resourceName != null)
+        {
+            if (firstSlashAdded) builder.append('/');
+            builder.append(_resourceName);
+            firstSlashAdded = true;
+        }
+        if (_resourceVersion != null)
+        {
+            if (firstSlashAdded) builder.append('/');
+            builder.append(_resourceVersion);
+            builder.append(
+                    _resourceName.substring(_resourceName.lastIndexOf('.')));
+            firstSlashAdded = true;
+        }
+
+        return builder.toString();
+    }
+
+    @Override
+    public boolean couldResourceContainValueExpressions()
+    {
+        return false;
+    }
+}

Modified: myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/resources/META-INF/faces-config.xml
URL: http://svn.apache.org/viewvc/myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/resources/META-INF/faces-config.xml?rev=1135285&r1=1135284&r2=1135285&view=diff
==============================================================================
--- myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/resources/META-INF/faces-config.xml (original)
+++ myfaces/commons/branches/jsf_20/myfaces-commons-resourcehandler/src/main/resources/META-INF/faces-config.xml Mon Jun 13 21:12:27 2011
@@ -23,7 +23,8 @@
               version="2.0">
 
     <application>
-        <resource-handler>org.apache.myfaces.commons.resourcehandler.AdvancedResourceHandler</resource-handler>
+        <!-- <resource-handler>org.apache.myfaces.commons.resourcehandler.AdvancedResourceHandler</resource-handler>  -->
+        <resource-handler>org.apache.myfaces.commons.resourcehandler.ExtendedResourceHandlerImpl</resource-handler>
     </application>
 
 </faces-config>
\ No newline at end of file