You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by "liwei li (Jira)" <ji...@apache.org> on 2021/09/10 09:10:00 UTC

[jira] [Created] (FLINK-24247) Uniformly limit the value of ABS(offset) in all window

liwei li created FLINK-24247:
--------------------------------

             Summary: Uniformly limit the value of ABS(offset)  in all window
                 Key: FLINK-24247
                 URL: https://issues.apache.org/jira/browse/FLINK-24247
             Project: Flink
          Issue Type: Improvement
          Components: API / DataStream
            Reporter: liwei li


when i test Window TVF offset([FLINK-23747|https://issues.apache.org/jira/browse/FLINK-23747?focusedCommentId=17410923&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17410923]), i found that TUMBLE WINDOW limit the value of ABS (offset) to be less than window size, but HOP\CUMULATE Windows does not have this limit. Do we  uniformly add this restriction to all of them? If add limit is appropriate, give me the ticket and I'll create a pr.

 

 
{code:java}
             checkArgument(
                    Math.abs(offset) < size,
                    String.format(
                            "Tumbling Window parameters must satisfy abs(offset) < size, bot got size %dms and offset %dms.",
                            size, offset));
{code}
 

[https://github.com/apache/flink/blob/c13b749782d0d72647ec6d73ce1eb22b57f2be7d/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java#L154]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)