You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spark.apache.org by CodingCat <gi...@git.apache.org> on 2014/02/19 01:20:03 UTC

[GitHub] incubator-spark pull request: fix site scala version error in doc

GitHub user CodingCat opened a pull request:

    https://github.com/apache/incubator-spark/pull/616

    fix site scala version error in doc

    fix site scala version error

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingCat/incubator-spark doc_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-spark/pull/616.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #616
    
----
commit eafd99a1ba740fcb0b54ab6244db8104f46db0aa
Author: CodingCat <zh...@gmail.com>
Date:   2014-02-19T00:22:52Z

    fix site scala version error in doc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by aarondav <gi...@git.apache.org>.

Github user aarondav commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35452922
  
    Thanks! Merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-spark/pull/616


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by pwendell <gi...@git.apache.org>.

Github user pwendell commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35459440
  
    Hey so I looked at it more closely, we need to look on a case-by-case basis where this is used. Some of the cases should be changed to 2.10.3 and others should stay as 2.10. I think most of them should stay as-is but we should probably rename what is now SCALA_VERSION to SCALA_BINARY_VERSION.
    
    The main one I think we need to change is in quick-start.md but there may be others as well. If you look at the release audit script, I did something similar there where we used both SCALA_VERSION and SCALA_BINARY_VERSION.
    
    https://github.com/pwendell/spark-utils/blob/master/release-audits/release_auditor.py#L19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by aarondav <gi...@git.apache.org>.

Github user aarondav commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35453423
  
    Also merged into branch-0.9, as we also use scala-2.10.3 there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by pwendell <gi...@git.apache.org>.

Github user pwendell commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35457550
  
    @aarondav this needs to be revered... it will break everywhere we tell people how to depend on Spark:
    
        scala-programming-guide.md:    artifactId = spark-core_{{site.SCALA_VERSION}}
    
    The issue is that in Scala 2.10+ artifacts are described as only 2.10. Probably we need to add a short scala version and a full length scala version and have two different variables in the docs:
    
    http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22spark-core_2.10%22



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by pwendell <gi...@git.apache.org>.

Github user pwendell commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35457734
  
    I reverted this in master and 0.9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by CodingCat <gi...@git.apache.org>.

Github user CodingCat commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35457861
  
    Sorry, @pwendell , I oversimplified the situation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] incubator-spark pull request: [SPARK-1105] fix site scala version ...

Posted by CodingCat <gi...@git.apache.org>.

Github user CodingCat commented on the pull request:

    https://github.com/apache/incubator-spark/pull/616#issuecomment-35454588
  
    thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---