Re: [PR] SPARK-52785: simplifying super() syntax in PySpark [spark]

["gaogaotiantian (via GitHub)" <gi...@apache.org>]

gaogaotiantian commented on PR #54790:
URL: https://github.com/apache/spark/pull/54790#issuecomment-4058759560

   Most of the changes in this PR are incorrect (semantics equivalent wise). I did this once and fixed most of the `super()` usages. The ones I left out were intentional.
   
   Basically
   
   ```python
   class A(B):
       def f(self):
           # equivalent to
           # super(A, self).f()
           # but NOT
           # super(B, self).f()
           super().f()
   ```
   
   So we can only change the ones that explicitly use the classes the methods are defined in (**not** their base class). I believe at least a few of them are super intentional to skip the methods of one of the parent classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org