You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/06 09:06:34 UTC

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1877: Fix twitter itest so it initially waits when start polling tweets

ppalaga commented on a change in pull request #1877:
URL: https://github.com/apache/camel-quarkus/pull/1877#discussion_r500121115



##########
File path: integration-tests/twitter/src/test/java/org/apache/camel/quarkus/component/twitter/CamelTwitterTest.java
##########
@@ -80,8 +80,10 @@ public void e2e() {
         final long sinceId = Long.parseLong(messageId) - 1;
         /* Check that the message is seen in the timeline by the polling consumer */
         {
+            final int initialDelayMs = 60000;
             final int retries = 5;
             final int delayMs = 3000;
+            Thread.sleep(initialDelayMs);

Review comment:
       This will prolong the test execution by 1 min even if the message appears in the timeline much earlier. Wouldn't it be better to increase the number of retries? Or wouldn't some shorter initialDelayMs work too? like 10 seconds?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org