[GitHub] [couchdb-erlfdb] kocolosk commented on a change in pull request #43: Refactor build matrix

[GitBox <gi...@apache.org>]

kocolosk commented on a change in pull request #43:
URL: https://github.com/apache/couchdb-erlfdb/pull/43#discussion_r747195867



##########
File path: .github/workflows/ci.yml
##########
@@ -63,25 +75,40 @@ jobs:
         with:
           persist-credentials: false
           submodules: recursive
-      - name: Install FoundationDB
-        env:
-          FDB_VERSION: ${{ matrix.fdb-version }}
-        # Download FDB .msi, install it, and add FDB to the $env:Path for all future steps
-        run: |
-          Set-PSDebug -Trace 1
-          Invoke-WebRequest -Uri https://www.foundationdb.org/downloads/$env:FDB_VERSION/windows/installers/foundationdb-$env:FDB_VERSION-x64.msi -OutFile foundationdb-$env:FDB_VERSION-x64.msi
-          msiexec /i foundationdb-$env:FDB_VERSION-x64.msi /passive
-          echo "c:/Program Files/foundationdb/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
       - name: Setup Erlang
         uses: ./.github/actions/setup-beam
         with:
           otp-version: '24'
           rebar3-version: '3.17'
       - name: Setup MSVC toolchain
+        if: ${{ matrix.os == 'windows-latest' }}
         uses: ./.github/actions/msvc-dev-cmd
+      - name: Install FoundationDB (Ubuntu)
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        run: |
+          wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+          wget https://www.foundationdb.org/downloads/${FDB_VERSION}/ubuntu/installers/foundationdb-server_${FDB_VERSION}-1_amd64.deb
+          sudo dpkg -i foundationdb-clients_${FDB_VERSION}-1_amd64.deb
+          sudo dpkg -i foundationdb-server_${FDB_VERSION}-1_amd64.deb
+      - name: Install FoundationDB (Windows)
+        if: ${{ matrix.os == 'windows-latest' }}
+        run: |
+          Set-PSDebug -Trace 1
+          Invoke-WebRequest -Uri https://www.foundationdb.org/downloads/$env:FDB_VERSION/windows/installers/foundationdb-$env:FDB_VERSION-x64.msi -OutFile foundationdb-$env:FDB_VERSION-x64.msi
+          msiexec /i foundationdb-$env:FDB_VERSION-x64.msi /passive
+          echo "c:/Program Files/foundationdb/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+      - name: Install FoundationDB (macOS)

Review comment:
       This step is dead code, I could remove it. I left it in there in case anyone cares to try to add macOS support for the `setup-beam` action in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org