Re: [PR] Add remote log upload support for callback subprocesses [airflow]

["ramitkataria (via GitHub)" <gi...@apache.org>]

ramitkataria commented on code in PR #66379:
URL: https://github.com/apache/airflow/pull/66379#discussion_r3345105085


##########
providers/elasticsearch/src/airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -691,8 +691,11 @@ def _get_source_includes(self, extra_fields: Iterable[str] = ()) -> list[str]:
             ["@timestamp", *TASK_LOG_FIELDS, self.host_field, self.offset_field, *extra_fields]
         )
 
-    def upload(self, path: os.PathLike | str, ti: RuntimeTI):
+    def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
         """Write the log to ElasticSearch."""
+        if ti is None:

Review Comment:
   Should we have a unit test for this path?



##########
providers/opensearch/src/airflow/providers/opensearch/log/os_task_handler.py:
##########
@@ -853,8 +853,11 @@ def __attrs_post_init__(self):
         self._doc_type_map: dict[Any, Any] = {}
         self._doc_type: list[Any] = []
 
-    def upload(self, path: os.PathLike | str, ti: RuntimeTI):
+    def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
         """Emit structured task logs to stdout and/or write them directly to OpenSearch."""
+        if ti is None:

Review Comment:
   Same here - a test for this branch would be good to have



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org