You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by shreyaspurohit <gi...@git.apache.org> on 2015/01/22 16:57:10 UTC
[GitHub] camel pull request: CAMEL-8265 Initial version of camel-hipchat co...
GitHub user shreyaspurohit opened a pull request:
https://github.com/apache/camel/pull/376
CAMEL-8265 Initial version of camel-hipchat component to integrate with Hipchat
@davsclaus @WillemJiang
Creates a new camel-hipchat component that can integrate with Hipchat. Following functionality are supported.
1. Send message to User and/or Room
2. Send text/html message with background color when supported
3. Notify the user/room of a new message
4. Consume latest message from user's using scheduled poll
Following things have been done as per http://camel.apache.org/add-new-component-guide.html
1. Jira: CAMEL-8265
2. All dependencies used where already present in apache camel. No new dependency added, hence no new license needs to be evaluated.
3. This PR
4. camel-hipchat component added to components pom modules section
5a. Every added source and resource contains the Apache license header.
5b. Component has an adequate test coverage.
5c. Build with checkstyle to ensure the sources are conform with the Apache Camel coding rules
5d. Producer log output is adequate on the INFO log level, the consumer is at DEBUG level as it is a polling consumer.
6. All dependencies used in this component already exist in Camel and hence they should already be OSGI compliant.
7. New feature added to platforms/karaf/features.
8. Submitted ICLA to get approval to edit wiki when this PR is merged.
9. Run maven clean install from new component directory
10. Add new component to parent/pom.xml and apache-camel/src/main/descriptors/common-bin.xml
Thing's I could not do:
1. mvn clean install -Pvalidate could not complete due to not related error:
[ERROR] Failed to execute goal org.apache.karaf.tooling:features-maven-plugin:2.4.1:validate (validate) on project apache-camel: Unable to validate F:
\Projects\Java\camel\platforms\karaf\features\target\classes\features.xml: Could not transfer artifact org.apache.cxf.karaf:apache-cxf:xml:features:3.
0.3 from/to google.script.repo (http://scriptengines.googlecode.com/svn/m2-repo/): No connector available to access repository google.script.repo (htt
p://scriptengines.googlecode.com/svn/m2-repo/) of type default using the available factories WagonRepositoryConnectorFactory
[ERROR] org.apache.cxf.karaf:apache-cxf:xml:3.0.3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shreyaspurohit/camel camel-hipchat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/376.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #376
----
commit 438c28eadf35028b2165503d6f9f66641c29c553
Author: Shreyas Purohit <sh...@gmail.com>
Date: 2015-01-22T15:53:21Z
CAMEL-8265 Initial version of camel-hipchat component to integrate with Hipchat
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] camel pull request: CAMEL-8265 camel-hipchat component to integrat...
Posted by shreyaspurohit <gi...@git.apache.org>.
Github user shreyaspurohit closed the pull request at:
https://github.com/apache/camel/pull/376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---