Which type of error handling goes well with the .validate() DSL?

[Matt Sicker <bo...@gmail.com>]

I have a common pattern right now of adding .validate() to several REST DSL
params since the .required() swagger DSL appears to be a suggestion and not
a validation. Since my REST DSL is spread across several routes, I'd like
to use some sort of shared error handling. Now I see there are two good
methods here that I'm debating between:

1. Use onException() in an abstract class and have all my RouteBuilders
inherit from that in order to reuse the same onException() block (which is
somewhat annoying because if you use the XML DSL instead, the same
<onException/> applies to the whole CamelContext apparently, but not when
you use the Java DSL).

2. Export an ErrorHandlerFactory service bean and reuse that in each
RouteBuilder on the specific routes that have a .validate().

I'm using Camel 2.16.2 if that matters.

-- 
Matt Sicker <bo...@gmail.com>

Re: Which type of error handling goes well with the .validate() DSL?

[Matt Sicker <bo...@gmail.com>]

I ended up using onException(PredicateValidationException.class) in an
abstract class that all my other routes inherit. These are all for REST DSL
type things, so they all live in the same bundle/module as it is. I decided
against the ErrorHandlerFactory OSGi service idea as it's possible that
other bundles will want to handle PredicateValidationExceptions in their
own way.

On 1 August 2016 at 11:01, Brad Johnson <br...@mediadriver.com>
wrote:

> Yes.  And since I started working with the SCR I was also looking to see if
> there was an EndpointInject or other annotation that would permit me to use
> items that way.  Since not I started on the annotation processing to make
> it available that way. But normally you could just use @EndpointInject.
>
> Brad
>
> On Mon, Aug 1, 2016 at 10:48 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> > That sounds like an interesting approach. Are you using a
> ProducerTemplate
> > then in the validation bean?
> >
> > On 1 August 2016 at 10:38, Brad Johnson <br...@mediadriver.com>
> > wrote:
> >
> > > It's funny but I was just wrestling with this issue.  I decided in my
> > > particular case not to use the .validate() but instead to use the
> > > .fliter().method("MyBeanValidator") which does a Boolean whether to
> > > continue or not.  But in the validator I have endpoints injected for
> > error
> > > handling.  In this case I'm firing off emails to administrators.  But
> if
> > > you can inject an endpoint then it can be used for pretty much
> anything.
> > >
> > > That way I'm not slinging exceptions and setting retries.  I find that
> > > mechanism rather clunky and better for a general safety net for the
> truly
> > > unexpected than for other errors.
> > >
> > > Obviously Camel has a lot of different ways to do things so it's pretty
> > > much a matter of taste I think.
> > >
> > > On Mon, Aug 1, 2016 at 10:03 AM, Matt Sicker <bo...@gmail.com> wrote:
> > >
> > > > I have a common pattern right now of adding .validate() to several
> REST
> > > DSL
> > > > params since the .required() swagger DSL appears to be a suggestion
> and
> > > not
> > > > a validation. Since my REST DSL is spread across several routes, I'd
> > like
> > > > to use some sort of shared error handling. Now I see there are two
> good
> > > > methods here that I'm debating between:
> > > >
> > > > 1. Use onException() in an abstract class and have all my
> RouteBuilders
> > > > inherit from that in order to reuse the same onException() block
> (which
> > > is
> > > > somewhat annoying because if you use the XML DSL instead, the same
> > > > <onException/> applies to the whole CamelContext apparently, but not
> > when
> > > > you use the Java DSL).
> > > >
> > > > 2. Export an ErrorHandlerFactory service bean and reuse that in each
> > > > RouteBuilder on the specific routes that have a .validate().
> > > >
> > > > I'm using Camel 2.16.2 if that matters.
> > > >
> > > > --
> > > > Matt Sicker <bo...@gmail.com>
> > > >
> > >
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
> >
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Which type of error handling goes well with the .validate() DSL?

[Brad Johnson <br...@mediadriver.com>]

Yes.  And since I started working with the SCR I was also looking to see if
there was an EndpointInject or other annotation that would permit me to use
items that way.  Since not I started on the annotation processing to make
it available that way. But normally you could just use @EndpointInject.

Brad

On Mon, Aug 1, 2016 at 10:48 AM, Matt Sicker <bo...@gmail.com> wrote:

> That sounds like an interesting approach. Are you using a ProducerTemplate
> then in the validation bean?
>
> On 1 August 2016 at 10:38, Brad Johnson <br...@mediadriver.com>
> wrote:
>
> > It's funny but I was just wrestling with this issue.  I decided in my
> > particular case not to use the .validate() but instead to use the
> > .fliter().method("MyBeanValidator") which does a Boolean whether to
> > continue or not.  But in the validator I have endpoints injected for
> error
> > handling.  In this case I'm firing off emails to administrators.  But if
> > you can inject an endpoint then it can be used for pretty much anything.
> >
> > That way I'm not slinging exceptions and setting retries.  I find that
> > mechanism rather clunky and better for a general safety net for the truly
> > unexpected than for other errors.
> >
> > Obviously Camel has a lot of different ways to do things so it's pretty
> > much a matter of taste I think.
> >
> > On Mon, Aug 1, 2016 at 10:03 AM, Matt Sicker <bo...@gmail.com> wrote:
> >
> > > I have a common pattern right now of adding .validate() to several REST
> > DSL
> > > params since the .required() swagger DSL appears to be a suggestion and
> > not
> > > a validation. Since my REST DSL is spread across several routes, I'd
> like
> > > to use some sort of shared error handling. Now I see there are two good
> > > methods here that I'm debating between:
> > >
> > > 1. Use onException() in an abstract class and have all my RouteBuilders
> > > inherit from that in order to reuse the same onException() block (which
> > is
> > > somewhat annoying because if you use the XML DSL instead, the same
> > > <onException/> applies to the whole CamelContext apparently, but not
> when
> > > you use the Java DSL).
> > >
> > > 2. Export an ErrorHandlerFactory service bean and reuse that in each
> > > RouteBuilder on the specific routes that have a .validate().
> > >
> > > I'm using Camel 2.16.2 if that matters.
> > >
> > > --
> > > Matt Sicker <bo...@gmail.com>
> > >
> >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>

Re: Which type of error handling goes well with the .validate() DSL?

[Matt Sicker <bo...@gmail.com>]

That sounds like an interesting approach. Are you using a ProducerTemplate
then in the validation bean?

On 1 August 2016 at 10:38, Brad Johnson <br...@mediadriver.com>
wrote:

> It's funny but I was just wrestling with this issue.  I decided in my
> particular case not to use the .validate() but instead to use the
> .fliter().method("MyBeanValidator") which does a Boolean whether to
> continue or not.  But in the validator I have endpoints injected for error
> handling.  In this case I'm firing off emails to administrators.  But if
> you can inject an endpoint then it can be used for pretty much anything.
>
> That way I'm not slinging exceptions and setting retries.  I find that
> mechanism rather clunky and better for a general safety net for the truly
> unexpected than for other errors.
>
> Obviously Camel has a lot of different ways to do things so it's pretty
> much a matter of taste I think.
>
> On Mon, Aug 1, 2016 at 10:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> > I have a common pattern right now of adding .validate() to several REST
> DSL
> > params since the .required() swagger DSL appears to be a suggestion and
> not
> > a validation. Since my REST DSL is spread across several routes, I'd like
> > to use some sort of shared error handling. Now I see there are two good
> > methods here that I'm debating between:
> >
> > 1. Use onException() in an abstract class and have all my RouteBuilders
> > inherit from that in order to reuse the same onException() block (which
> is
> > somewhat annoying because if you use the XML DSL instead, the same
> > <onException/> applies to the whole CamelContext apparently, but not when
> > you use the Java DSL).
> >
> > 2. Export an ErrorHandlerFactory service bean and reuse that in each
> > RouteBuilder on the specific routes that have a .validate().
> >
> > I'm using Camel 2.16.2 if that matters.
> >
> > --
> > Matt Sicker <bo...@gmail.com>
> >
>



-- 
Matt Sicker <bo...@gmail.com>

Re: Which type of error handling goes well with the .validate() DSL?

[Brad Johnson <br...@mediadriver.com>]

It's funny but I was just wrestling with this issue.  I decided in my
particular case not to use the .validate() but instead to use the
.fliter().method("MyBeanValidator") which does a Boolean whether to
continue or not.  But in the validator I have endpoints injected for error
handling.  In this case I'm firing off emails to administrators.  But if
you can inject an endpoint then it can be used for pretty much anything.

That way I'm not slinging exceptions and setting retries.  I find that
mechanism rather clunky and better for a general safety net for the truly
unexpected than for other errors.

Obviously Camel has a lot of different ways to do things so it's pretty
much a matter of taste I think.

On Mon, Aug 1, 2016 at 10:03 AM, Matt Sicker <bo...@gmail.com> wrote:

> I have a common pattern right now of adding .validate() to several REST DSL
> params since the .required() swagger DSL appears to be a suggestion and not
> a validation. Since my REST DSL is spread across several routes, I'd like
> to use some sort of shared error handling. Now I see there are two good
> methods here that I'm debating between:
>
> 1. Use onException() in an abstract class and have all my RouteBuilders
> inherit from that in order to reuse the same onException() block (which is
> somewhat annoying because if you use the XML DSL instead, the same
> <onException/> applies to the whole CamelContext apparently, but not when
> you use the Java DSL).
>
> 2. Export an ErrorHandlerFactory service bean and reuse that in each
> RouteBuilder on the specific routes that have a .validate().
>
> I'm using Camel 2.16.2 if that matters.
>
> --
> Matt Sicker <bo...@gmail.com>
>