You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/10/06 11:10:52 UTC

[GitHub] [nifi] alien11689 opened a new pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

alien11689 opened a new pull request #4575:
URL: https://github.com/apache/nifi/pull/4575


   Fixes NIFI-7882
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] MikeThomsen commented on pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on pull request #4575:
URL: https://github.com/apache/nifi/pull/4575#issuecomment-704369485


   Avro 1.10.0 is using Jackson 2 now, so it would be worthwhile to check a new Avro build to see if the behavior is the same.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] github-actions[bot] commented on pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #4575:
URL: https://github.com/apache/nifi/pull/4575#issuecomment-819929715


   We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable.  If you would like this PR re-opened you can do so and a committer can remove the stale tag.  Or you can open a new PR.  Try to help review other PRs to increase PR review bandwidth which in turn helps yours.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] github-actions[bot] closed pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #4575:
URL: https://github.com/apache/nifi/pull/4575


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] alien11689 commented on pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

Posted by GitBox <gi...@apache.org>.
alien11689 commented on pull request #4575:
URL: https://github.com/apache/nifi/pull/4575#issuecomment-704706942


   Bumping Avro to 1.9 or 1.10 is one of the available solutions, but it definitely should bump nifi minor version (1.12 -> 1.13). And of course it should be done.
   
   But for fixing the problem as soon as possible this change is good enough. Nifi version could be bumped only with patch version and versions 1.11.5 and 1.12.2 could be released.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] alien11689 commented on pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

Posted by GitBox <gi...@apache.org>.
alien11689 commented on pull request #4575:
URL: https://github.com/apache/nifi/pull/4575#issuecomment-707499821


   Hi, I set Unix-style file endings for new files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] mattyb149 commented on pull request #4575: [NIFI-7882] Handle JsonProperties as avro field default

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #4575:
URL: https://github.com/apache/nifi/pull/4575#issuecomment-707311442


   Code LGTM but the test input/output files appear to have Windows-style line endings. Could you ensure the changed lines and new files have Unix-style line endings? Should be ready to merge after that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org